[gardenlet] Introduce controller-runtime manager
#6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
the
size/XXL
76 tasks
|
/assign @oliver-goetz |
rfranzke
force-pushed
the
enh/cr-gardenlet
branch
from
74bf83d
to
82be32f
Compare
acumino
reviewed
Sep 19, 2022
These tests don't belong to the `controller` packages but rather to the `imagevector` package.
Pointer types are removed now just like in the component configs for GCM, scheduler, GAC, etc.
The config structure is similar to admission-controller and controller-manager now and fits to the `manager.Options` structure as well.
So that it can be reused in `gardenlet` later on
Previously, this was logged in the gardenlet's `app.go`, but the seed controller is the only entity which requires the client certificate object. So, better move this here instead of transporting the information through many different intermediate instances.
The health manager in gardenlet will be registered as `manager.Runnable` in the future.
The client map for shoots in gardenlet will be registered as `manager.Runnable` in the future.
This function will be ran as `manager.Runnable`, so make sure that it blocks as long as it is actively waiting (previously the function was starting a goroutine and returning immediately, but this doesn't play nicely with `manager.Runnable` way of running code).
So that garden client is no longer fetched from client map
The gardenlet will have the garden and seed clients already available when creating the client map, so we can pass them right away.
Typically, runnables added to the a manager are all started in parallel, hence uncontrolled. In the gardenlet case, we first want to perform a few bootstrap tasks (like validating the seed config or fetching a client certificate for the garden cluster) before we start the actual runnables (controllers, etc.). The introduced `Runner` is capable of achieving this goal by first starting all bootstrap runnables and only adding the actual runnables once all bootstrap runnables completed successfully.
Earlier, this client was used when instantiating a new `kubernetes.Interface`, however the gardenlet will now instantiate the clients using the controller-runtime's manager. Hence, we have to make this function public so that we can use provide it to the `manager.Options.NewClientFunc`.
We will be only using the HTTP servers that already come with the controller-runtime's `Manager`, so we don't need this package anymore.
We don't need the garden or seed client maps anymore, and we allso don't need the delegating client map. Only shoot client maps will remain.
The will be provided with the `cluster.Cluster` or client objects from the factory when the controllers are instantiated. Also, there will be no ClientMap anymore for garden/seed, so related coding can be cleaned up/deleted.
This is to have aligned names of the clients across code and components. Also, "ClientSet` hints that it's not `client.Client` but `kubernetes.Interface`.
This is to have aligned names of the clients across code and components. Also, "ClientSet` hints that it's not `client.Client` but `kubernetes.Interface`.
In the future, there will be no client maps for garden or seed clusters anymore (no longer needed). Hence, let's make sure that this client map is for shoot clusters only.
This is to have aligned names of the clients across code and components. Also, "Client` hints that it's `client.Client` and not `kubernetes.Interface`.
The gardenlet will have the seed client always available, no need to initialize it anymore.
rfranzke
force-pushed
the
enh/cr-gardenlet
branch
from
f9d8d16
to
596e058
Compare
rfranzke
force-pushed
the
enh/cr-gardenlet
branch
from
596e058
to
11c7f90
Compare
|
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
rfranzke
changed the title
controller-runtime manager in gardenletcontroller-runtime manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Introduce
controller-runtimemanager ingardenlet.No controllers have been refactored yet.
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Similar to #6333.
Release note: