-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline gardener-controller-manager
controllers after refactorings
#6699
Conversation
similar to other controllers
/cc @ary1992 |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Just a minor comment. Apart from that lgtm.
...erregistration/controllerregistrationfinalizer/controllerregistrationfinalizer_suite_test.go
Outdated
Show resolved
Hide resolved
…llerregistrationfinalizer/controllerregistrationfinalizer_suite_test.go Co-authored-by: Ashish Ranjan Yadav <ashish.ranjan.yadav@sap.com>
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ary1992 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
This PR streamlines a few nits after the many refactors of the controllers part of
gardener-controller-manager
.Which issue(s) this PR fixes:
Part of #4251
Release note: