Streamline webhook handler registration in gardener-admission-controller
#6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
76 tasks
gardener-prow
bot
added
the
size/XXL
|
/assign |
rfranzke
force-pushed
the
streamline/gac
branch
from
51daef6
to
b6a5219
Compare
acumino
reviewed
Oct 28, 2022
pkg/admissioncontroller/webhook/admission/kubeconfigsecret/handler.go
Outdated
Show resolved
Hide resolved
rfranzke
force-pushed
the
streamline/gac
branch
from
b6a5219
to
4a1f4ec
Compare
|
/test pull-gardener-integration |
timuthy
requested changes
Nov 1, 2022
pkg/admissioncontroller/webhook/admission/internaldomainsecret/handler.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/webhook/admission/internaldomainsecret/handler.go
Show resolved
Hide resolved
pkg/admissioncontroller/webhook/admission/internaldomainsecret/handler.go
Show resolved
Hide resolved
…ret` admission handler This is unreachable code since there would not be a 'Create' event when the exact same secret already exists.
…nd seed namespaces in all cases
…ts when role label gets newly added
rfranzke
force-pushed
the
streamline/gac
branch
from
4a1f4ec
to
63a6767
Compare
|
/test pull-gardener-e2e-kind-ha-zone |
timuthy
reviewed
Nov 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
rfranzke
changed the title
gardener-admission-controllergardener-admission-controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup technical-debt
What this PR does / why we need it:
This PR streamlines the webhook handler registration in
gardener-admission-controllerso that it's similar to what happens for the webhooks ingardener-resource-manager(see #6865), and generally similar to the registration of controllers in other components (garden{er-controller-manager,er-scheduler,let}).Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Similar to #6865.
Release note: