-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline gardener-resource-manager
entrypoint and introduce component configuration
#6865
Conversation
1a3dcfb
to
7301cbb
Compare
7301cbb
to
9eb7ef2
Compare
/assign |
Typically we use singular for these names (e.g. there is also `controller` package and not `controllerS`)
Instead of computing CLI flags, we now compute the configuration - much cleaner.
9eb7ef2
to
abf0438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently in the middle of commit Rework main entrypoint
. Some nits I discovered so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some bits and pieces in the helm chart.
Otherwise 🚀
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/runtime/templates/deployment.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/runtime/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
This was also not done before but a premature optimization as part of this PR. However, we have to revert it because the GRM for shoots handles not only the kube-system namespace in the shoot but also other namespaces (e.g., kubernetes-dashboard).
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-gardener-e2e-kind |
gardener-resource-manager
entrypoint and introduce component configurationgardener-resource-manager
entrypoint and introduce component configuration
How to categorize this PR?
/area dev-productivity
/kind cleanup technical-debt
What this PR does / why we need it:
This PR streamlines the
gardener-resource-manager
entrypoint as well as all controllers and webhooks so that it is aligned with other components likegarden{er-controller-manager,er-scheduler,let}
.It also introduces a component config API for GRM (previously it was using CLI flags only).
Which issue(s) this PR fixes:
Part of #4251
Release note: