Streamline gardener-resource-manager entrypoint and introduce component configuration
#6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
the
size/XXL
76 tasks
rfranzke
force-pushed
the
refactor/grm
branch
from
1a3dcfb
to
7301cbb
Compare
rfranzke
force-pushed
the
refactor/grm
branch
from
7301cbb
to
9eb7ef2
Compare
|
/assign |
Typically we use singular for these names (e.g. there is also `controller` package and not `controllerS`)
Instead of computing CLI flags, we now compute the configuration - much cleaner.
rfranzke
force-pushed
the
refactor/grm
branch
from
9eb7ef2
to
abf0438
Compare
oliver-goetz
requested changes
Oct 25, 2022
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/runtime/templates/deployment.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/application/templates/mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
charts/gardener/resource-manager/charts/runtime/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
This was also not done before but a premature optimization as part of this PR. However, we have to revert it because the GRM for shoots handles not only the kube-system namespace in the shoot but also other namespaces (e.g., kubernetes-dashboard).
|
/lgtm |
oliver-goetz
approved these changes
Oct 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/test pull-gardener-e2e-kind |
rfranzke
changed the title
gardener-resource-manager entrypoint and introduce component configurationgardener-resource-manager entrypoint and introduce component configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup technical-debt
What this PR does / why we need it:
This PR streamlines the
gardener-resource-managerentrypoint as well as all controllers and webhooks so that it is aligned with other components likegarden{er-controller-manager,er-scheduler,let}.It also introduces a component config API for GRM (previously it was using CLI flags only).
Which issue(s) this PR fixes:
Part of #4251
Release note: