Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #6956

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #6956

merged 1 commit into from
Nov 7, 2022

Conversation

dimitar-kostadinov
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind cleanup

What this PR does / why we need it:
Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations

Which issue(s) this PR fixes:
Fixes #kubernetes/kubernetes#79548

Special notes for your reviewer:

Release note:

scheduler.alpha.kubernetes.io/critical-pod annotation is removed as pod priority (spec.priorityClassName) is used instead to mark pods as critical

@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 4, 2022
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2022
rfranzke
rfranzke reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@gardener-prow gardener-prow bot merged commit a044589 into gardener:master Nov 7, 2022
@dimitar-kostadinov dimitar-kostadinov deleted the remove-critical-pod-annotation branch May 22, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimitar-kostadinov @rfranzke