Adapt high-availability configuration of shoot system components #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
do-not-merge/work-in-progress
gardener-prow
bot
added
cla: yes
56 tasks
rfranzke
force-pushed
the
enh/ha-adapt-shoot
branch
from
89b8906
to
058c933
Compare
rfranzke
force-pushed
the
enh/ha-adapt-shoot
branch
from
058c933
to
2e23a7e
Compare
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
|
/test pull-gardener-integration |
|
/assign |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/milestone v1.60 |
|
/test pull-gardener-integration |
ScheererJ
added a commit
to ScheererJ/gardener
that referenced
this pull request
Dec 1, 2022
…ility handling. With PR gardener#6989 high-availability handling was introduced to coredns and other components. While it works nicely with the default scenario with horizontal pod autoscaler, it fails in combination with the cluster-proportional autoscaling approach. In the latter case the autoscaler and the gardener-resource-manager race towards changing the replica count of the coredns deployment. As a result, pods are created/terminated constantly. With this change, the replica mutation of the high-availability handling is disabled in case coredns uses the cluster-proportional autoscaling approach.
gardener-prow bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
…ility handling. (#7129) With PR #6989 high-availability handling was introduced to coredns and other components. While it works nicely with the default scenario with horizontal pod autoscaler, it fails in combination with the cluster-proportional autoscaling approach. In the latter case the autoscaler and the gardener-resource-manager race towards changing the replica count of the coredns deployment. As a result, pods are created/terminated constantly. With this change, the replica mutation of the high-availability handling is disabled in case coredns uses the cluster-proportional autoscaling approach.
gardener-ci-robot
pushed a commit
to gardener-ci-robot/gardener
that referenced
this pull request
Dec 1, 2022
…ility handling. With PR gardener#6989 high-availability handling was introduced to coredns and other components. While it works nicely with the default scenario with horizontal pod autoscaler, it fails in combination with the cluster-proportional autoscaling approach. In the latter case the autoscaler and the gardener-resource-manager race towards changing the replica count of the coredns deployment. As a result, pods are created/terminated constantly. With this change, the replica mutation of the high-availability handling is disabled in case coredns uses the cluster-proportional autoscaling approach.
gardener-prow bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
…ility handling. (#7131) With PR #6989 high-availability handling was introduced to coredns and other components. While it works nicely with the default scenario with horizontal pod autoscaler, it fails in combination with the cluster-proportional autoscaling approach. In the latter case the autoscaler and the gardener-resource-manager race towards changing the replica count of the coredns deployment. As a result, pods are created/terminated constantly. With this change, the replica mutation of the high-availability handling is disabled in case coredns uses the cluster-proportional autoscaling approach. Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area high-availability
/kind enhancement
What this PR does / why we need it:
This PR adapts the HA configuration of the non-observability-related shoot system components.
Concretely, the components are labeled according to their type and custom replica/affinity changes have been dropped.
The webhook introduced with #6967 will take care to properly inject the required HA configuration.
Which issue(s) this PR fixes:
Part of #6529
Similar to #6982 and #6992
Special notes for your reviewer:
✅
Depends on #6967 which needs to be merged first./cc @timuthy
Release note: