Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt high-availability configuration of shoot control plane components #6992

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area high-availability
/kind enhancement

What this PR does / why we need it:
This PR adapts the HA configuration of the non-observability-related shoot control plane components.
Concretely, the components are labeled according to their type and custom replica/affinity changes have been dropped.
The webhook introduced with #6967 will take care to properly inject the required HA configuration.

Which issue(s) this PR fixes:
Part of #6529
Similar to #6982 and #6989

Special notes for your reviewer:
Depends on #6967 which needs to be merged first.

/cc @timuthy

Release note:

All non-observability-related shoot control plane components are now running with configuration for high-availability according to [the conventions](https://github.com/gardener/gardener/blob/master/docs/development/high-availability.md).

@gardener-prow gardener-prow bot requested a review from timuthy November 11, 2022 04:58
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/high-availability High availability related kind/enhancement Enhancement, improvement, extension labels Nov 11, 2022
@rfranzke rfranzke marked this pull request as ready for review November 11, 2022 04:58
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 11, 2022
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2022
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 14, 2022

@rfranzke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 3c859ac link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@acumino
Copy link
Member

acumino commented Nov 15, 2022

/cc @rfranzke is this supposed to go in v1.60?

@timuthy
Copy link
Contributor

timuthy commented Nov 15, 2022

@acumino it'd be nice to have this in v1.60 🙂

@acumino
Copy link
Member

acumino commented Nov 15, 2022

/milestone v1.60

@gardener-prow gardener-prow bot added this to the v1.60 milestone Nov 15, 2022
@gardener-prow gardener-prow bot merged commit 73c9272 into gardener:master Nov 15, 2022
@rfranzke rfranzke deleted the enh/ha-adapt-cp branch November 15, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/high-availability High availability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants