🧹 Cleanup a few TODOs

[rfranzke]

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:

• Remove cleanup code for orphaned ServiceAccounts related to garden access secrets for extensions, introduced with Clean up orphaned ServiceAccounts related to garden access secrets for extensions #8697, released with v1.83.0
• Remove recreation code for ManagedResource secrets that have deletionTimestamps, introduced with Recreate managed resource secrets that have deletion timestamp #8812, released with v1.84.0
• Remove vali test code checking for auth enabled, introduced with Remove obsolete vali tenant configurations #8800, released with v1.85.0
• Remove deprecated .spec.dns.providers[].{domains,zones} fields, introduced with Clean up DNS handling #8199, released with v1.75.0
• Remove cleanup of old unsupported ClusterRoleBinding for MCM, introduced with Clean-up old unsupported ClusterRoleBinding for MCM before deploying new one #8816, released with v1.85.0

Special notes for your reviewer:
FYI @timuthy @nickytd @MartinWeindel

Release note:

NONE

[nickytd]

/lgtm

[gardener-prow]

LGTM label has been added.

Git tree hash: 233072c8c2a4112559cfdba700ba065c965a2366

[timuthy]

/lgtm

[oliver-goetz]

/retest

[MartinWeindel]

Remove deprecated .spec.dns.providers[].{domains,zones} fields

This change needs some adjustments in the shoot-dns-service admission webhook. The providers must not be synchronised anymore. The question is how to control the behaviour switch. Should it be activated if the next new release of the shoot-dns-service is deployed or should it better depend on the Gardener version?

[rfranzke]

Remove deprecated .spec.dns.providers[].{domains,zones} fields

This change needs some adjustments in the shoot-dns-service admission webhook. The providers must not be synchronised anymore. The question is how to control the behaviour switch. Should it be activated if the next new release of the shoot-dns-service is deployed or should it better depend on the Gardener version?

What happens if this PR is deployed without updating shoot-dns-service?

[rfranzke]

/hold

We might need to drop 91f2d01 from this PR, cc @timuthy @MartinWeindel

[MartinWeindel]

/hold

We might need to drop 91f2d01 from this PR, cc @timuthy @MartinWeindel

The Gardener Dashboard needs probably also make some adjustments to read/write the DNS Providers from/to the extensions provider config section and not by the .spec.DNS.providers section. @grolu @holgerkoser @petersutter

[rfranzke]

Well, then I guess it makes sense to indeed drop this commit from this PR and delay the removal for another 3 months or so (~6 releases).

[rfranzke]

I've removed the commit from the PR and updated the TODO statement accordingly. @timuthy @MartinWeindel please follow-up with all involved entities (shoot-dns-service extension, dashboard, stakeholder announcement, ...) so that we can make the removal next time.

[rfranzke]

/unhold

@timuthy @ScheererJ I guess we can go ahead with this PR.

[timuthy]

Just some bureaucratic concerns 😄

[timuthy]

Thank you!
/lgtm
/approve

[gardener-prow]

LGTM label has been added.

Git tree hash: caddfcd9b58008fe2ea104817504bc115f2a41f8

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [timuthy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oliver-goetz]

/retest