Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop UseGardenerNodeAgent feature gate, cloud-config-{downloader,executor}, and oscommon package 🧹 #9477

Merged
merged 12 commits into from Mar 27, 2024
Merged

Drop UseGardenerNodeAgent feature gate, cloud-config-{downloader,executor}, and oscommon package 🧹 #9477

merged 12 commits into from Mar 27, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Mar 26, 2024 •
edited by oliver-goetz

How to categorize this PR?

/area open-source
/kind cleanup

What this PR does / why we need it:

  • This PR drops the graduated UseGardenerNodeAgent feature gate as well as all migration code related to it.
  • This allows dropping cloud-config-downloader and cloud-config-executor bash scripts.

Which issue(s) this PR fixes:
Part of #8023
Fixes #4673

Special notes for your reviewer:
/cc @oliver-goetz @ScheererJ
🥂 kudos and many thanks to everybody involved, cc @majst01 @Gerrit91 @timebertt @vknabel and others 🍻

Release note:

The graduated `UseGardenerNodeAgent` feature gate has been dropped. Before upgrading to this Gardener version, make sure to have up-to-date OS extensions installed on your landscape: `os-gardenlinux@v0.24+`, `os-ubuntu@v1.25+`, `os-suse-chost@v1.25+`, `os-coreos@v1.20+`, `os-metal@v0.8+`, `provider-aws@v1.53.2+`.

The deprecated `oscommon` package has been removed.

The following fields in the`extensions.gardener.cloud/v1alpha1.OperatingSystemConfig` API have been deprecated and will be removed in a future version: `.spec.reloadConfigFilePath`, `.status.command`, `.status.units`, `.status.files`.

@gardener-prow gardener-prow bot added the area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related label Mar 26, 2024
@gardener-prow gardener-prow bot requested a review from ScheererJ March 26, 2024 16:23
@gardener-prow gardener-prow bot added kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2024
@rfranzke rfranzke mentioned this pull request Mar 26, 2024
Closed
55 tasks
@rfranzke rfranzke changed the title Drop UseGardenerNodeAgent feature gate, cloud-config-{downloader,executor}, and oscommon package 🧹🧹 Drop UseGardenerNodeAgent feature gate, cloud-config-{downloader,executor}, and oscommon package 🧹 Mar 26, 2024
@rfranzke rfranzke force-pushed the drop/ccd branch 3 times, most recently from e3a993d to 84b7c74 Compare March 26, 2024 17:17
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@timebertt
Copy link
Member

There should be a 🍻 reaction for PRs like this.
Thanks, everybody. Well done! 👏

@majst01
Copy link
Contributor

majst01 commented Mar 27, 2024

There should be a 🍻 reaction for PRs like this. Thanks, everybody. Well done! 👏

We can 🍻 at the Hackathon then :-)

ScheererJ
ScheererJ reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change. Only found a small thing. Looks good otherwise.

pkg/component/extensions/operatingsystemconfig/operatingsystemconfig_test.go Show resolved Hide resolved
@rfranzke rfranzke requested a review from ScheererJ March 27, 2024 14:27
ScheererJ
ScheererJ reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 27, 2024

LGTM label has been added.

Git tree hash: 334d0797a87b012ddb56ff16d31910d2c76311f5

oliver-goetz
oliver-goetz approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell bash 🧹
-4875 lines...nice cleanup thanks 🚀

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@gardener-prow gardener-prow bot merged commit 84f5256 into gardener:master Mar 27, 2024
17 checks passed
@rfranzke rfranzke deleted the drop/ccd branch March 28, 2024 08:31
This was referenced Apr 4, 2024
Merged
Merged
@timebertt
Copy link
Member

Great release note. Love the list of extension version requirements!

@rfranzke rfranzke mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

@oliver-goetz oliver-goetz oliver-goetz approved these changes

Assignees

@ScheererJ ScheererJ

@oliver-goetz oliver-goetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of docker in Gardener, such that Gardener can use OS images without docker daemon installed
5 participants
@rfranzke @timebertt @majst01 @ScheererJ @oliver-goetz