-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent GNA image tag defaulting with K8s version #9578
Conversation
/cherry-pick release-v1.92 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.92 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @oliver-goetz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy 馃槤
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: fe34cbf21b7892d25b71731690d0e75e8874357c
|
@rfranzke: new pull request created: #9582 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How to categorize this PR?
/area usability
/kind regression
What this PR does / why we need it:
https://github.com/gardener/gardener/pull/9477/files#diff-38d05f084de4de6e6424bae70053842cf593786e9dd357a4262025ff078810a4L53-L69 accidentally introduced a bug (see code document in the changes) which caused
gardenlet
to try deployinggardener-node-agent
with a wrong image tag.This PR fixes this regression.
We haven't noticed this in the e2e tests because we use image vector overwrites for the Gardener images (since they get freshly built by skaffold). This bug only occurs when no image vector overwrite for
gardener-node-agent
is used.Which issue(s) this PR fixes:
Fixes #9577
Special notes for your reviewer:
Thanks @lotharbach for reporting 馃殌
Follow-up of #9477
Release note: