Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GNA image tag defaulting with K8s version #9578

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area usability
/kind regression

What this PR does / why we need it:
https://github.com/gardener/gardener/pull/9477/files#diff-38d05f084de4de6e6424bae70053842cf593786e9dd357a4262025ff078810a4L53-L69 accidentally introduced a bug (see code document in the changes) which caused gardenlet to try deploying gardener-node-agent with a wrong image tag.
This PR fixes this regression.

We haven't noticed this in the e2e tests because we use image vector overwrites for the Gardener images (since they get freshly built by skaffold). This bug only occurs when no image vector overwrite for gardener-node-agent is used.

Which issue(s) this PR fixes:
Fixes #9577

Special notes for your reviewer:
Thanks @lotharbach for reporting 馃殌
Follow-up of #9477

Release note:

A bug has been fixed which caused `gardenlet` to try deploying `gardener-node-agent` with a wrong image tag.

@gardener-prow gardener-prow bot added the area/usability Usability related label Apr 12, 2024
@gardener-prow gardener-prow bot added kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 12, 2024
@rfranzke
Copy link
Member Author

/cherry-pick release-v1.92

@gardener-ci-robot
Copy link
Contributor

@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.92 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2024
@rfranzke
Copy link
Member Author

/cc @oliver-goetz

Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy 馃槤

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

gardener-prow bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

gardener-prow bot commented Apr 12, 2024

LGTM label has been added.

Git tree hash: fe34cbf21b7892d25b71731690d0e75e8874357c

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@gardener-prow gardener-prow bot merged commit 669f88f into gardener:master Apr 12, 2024
17 checks passed
@gardener-ci-robot
Copy link
Contributor

@rfranzke: new pull request created: #9582

In response to this:

/cherry-pick release-v1.92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-agent image tag in OperatingSystemConfig uses shoot kubernetes version instead of gardener version
3 participants