[GEP-19] Integrate long-term Prometheus deployment into Garden controller
#9606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
46 tasks
rfranzke
force-pushed
the
gep19/longterm-prom
branch
from
83ba80c
to
f02f0bc
Compare
|
/assign |
ScheererJ
reviewed
Apr 19, 2024
rfranzke
force-pushed
the
gep19/longterm-prom
branch
from
f02f0bc
to
e855f34
Compare
ScheererJ
reviewed
Apr 19, 2024
|
LGTM label has been added. Git tree hash: c0d74d679a7bdb8889c5452316403ae2f3a94339
|
gardener-prow
bot
added
the
needs-rebase
The longterm Prometheus uses this for caching, see docs (first commit)
Also adapt Plutono dashboard datasources This Prometheus has a cortex sidecar which serves as frontend, so the port must be 9091 (cortex container port)
rfranzke
force-pushed
the
gep19/longterm-prom
branch
from
e855f34
to
6bcdd63
Compare
|
New changes are detected. LGTM label has been removed. |
gardener-prow
bot
removed
the
needs-rebase
|
Already |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9606, released with `v1.94.0`)
Merged
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9606, released with `v1.94.0`)
gardener-prow bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Remove deprecated fields from `OperatingSystemConfig` (from #9477, released with `v1.92.0`) * Remove cleanup of old `kube-apiserver` `Ingress` resource (from #9300, released with `v1.91.0`) * Remove Istio zone migration code (from #9304 and #9457, released with `v1.91.0` and `v1.92.0`) * Increase removal period of `<name>.ca-cluster` `Secret` To give users more time to adapt * Remove PVC migration for `garden` Prometheus (from #9543, released with `v1.93.0`) * Remove PVC migration for `longterm` Prometheus (from #9606, released with `v1.94.0`) * Drop migration code in `skaffold.yaml` for `core.gardener.cloud/v1` API (from #9771, released with `v1.96.0`) * Remove migration code for e2e upgrade tests after `provider-local` VPN fix (from #9752, released with `v1.96.0`) * Remove cleanup of old `vali` `VerticalPodAutoscaler`s (from #9681, released with `v1.94.0`) * Remove cleanuop code after making `Secret`s of `ManagedResource`s immutable (from #8116, released with `v1.77.0`) * Remove cleanup code of resources of legacy `cloud-config-downloader` (from #8847, released with `v1.85.0`) * Revert "Remove Istio zone migration code" This reverts commit 8850346. * Increase removal period of Istio zone migration code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity monitoring
/kind enhancement
What this PR does / why we need it:
gardener-operatornow deploys two Prometheus replicas into thegardennamespace for long-term retention of some metrics (e.g., availability/SLI or metering data).This also features a cortex frontend for caching purposes.
Which issue(s) this PR fixes:
Part of #9065
Special notes for your reviewer:
/cc @ScheererJ
FYI @istvanballok @vicwicker
Release note:
`gardener-operator` now deploys two more Prometheus replicas into the `garden` namespace for storing long-term metrics. Read more about it [here](https://github.com/gardener/gardener/blob/master/docs/concepts/operator.md#long-term-prometheus).