Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selector in the internal cache of required #33

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

ggaurav10
Copy link
Contributor

What this PR does / why we need it:
Update selector in the internal cache of required

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@ggaurav10 ggaurav10 requested a review from a team as a code owner September 18, 2019 05:44
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 18, 2019
Copy link
Collaborator

@amshuman-kr amshuman-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM But let's see if we can avoid the cache as being discussed in #32.

@amshuman-kr amshuman-kr merged commit d91ac6f into gardener:master Sep 18, 2019
@ggaurav10 ggaurav10 deleted the selector branch September 19, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants