Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -mod=vendor #291

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Use -mod=vendor #291

merged 1 commit into from
Jul 11, 2019

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
For cmd/go the default behaviour in go modules is to look up the proper modules through the network. -mod=vendor prevents that and forces the use of vendor/.
Ref golang/go#27227

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@ialidzhikov
Use -mod=vendor
86878c9 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from ggaurav10 and a team as code owners July 10, 2019 13:45
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 10, 2019
prashanth26
prashanth26 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@prashanth26 prashanth26 merged commit 55ee691 into gardener:master Jul 11, 2019
@ialidzhikov ialidzhikov deleted the enh/use-mod-vendor branch July 11, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ialidzhikov @prashanth26 @gardener-robot-ci-1