Improved log details to include node name and provider ID #607

himanshu-kun · 2021-05-10T08:24:16Z

print logic for nodeName and providerID with machineName at key places added

What this PR does / why we need it:
this PR prints nodeName and provider-ID also ,with machineName so that it eases debugging
Which issue(s) this PR fixes:
Fixes #606

Special notes for your reviewer:
I have made changes only for Info logs not for error logs
Release note:

Improved log details to include node name and provider-ID in addition to existing machine name

gardener-robot · 2021-05-10T08:24:20Z

@himanshu-kun Thank you for your contribution.

gardener-robot-ci-1 · 2021-05-10T08:24:31Z

Thank you @himanshu-kun for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

pkg/util/provider/machinecontroller/machine_util.go

prashanth26

Thanks for these changes @himanshu-kun . Very nice.

Can you check this one file as well? Specially in the section of drain tagged here. Or any other logs you feel would help us with debugging.

pkg/util/provider/machinecontroller/machine_util.go

print logic for nodeName and providerID with machineName at key places added

himanshu-kun

let me know if you want changes at any other places

pkg/util/provider/machinecontroller/machine_util.go

prashanth26

Just couple of minor typos. You can accept these changes as a github UI commit itself. I can squash and merge while merging it in.

/lgtm otherwise.

pkg/util/provider/machinecontroller/machine.go

pkg/util/provider/machinecontroller/machine_util.go

Co-authored-by: Prashanth <prashanth@sap.com>

* Prepare Next Dev Cycle v0.35.0-dev * Wait also for CSI PVs during serial eviction Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * add servergroup option * [azure] Verify tags Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com> * Allow deletion of machines where modify instance fails on deletion * [OOT] Re-enabled support for bootstrap token injection Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com> * Azure MachineSet: VM ScaleSet or AvailabilitySet Add generic MachineSet configuration in AzureMachineClass. The machineSet field can be used to configure either a VMO or an AvailabilitySet for a MachineClass. The availabilitySets field will be kept for a while but is now deprecated in favour of the machineset field. The Azure compute sdk is also updated to support VMSS/VMO. * Introduce constant backoff while enqueuing machine objects on creation and deletion failures Co-authored-by: Prashanth <prashanth@sap.com> * Bugfix: Finalizers are added by default on MC * Added event handlers for MachCls Fixed minor typo * Removed multiple machineClass adds when pointing to same class.kind * Fix typo in documentation The documentation was pointing to the wrong branch. This change fixes it. * Improve documentation with FAQ Co-authored-by: Prashanth <prashanth@sap.com> Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> * Enable NetworkUnavailable as node condition for machine health (gardener#543) Add NetworkUnavailable as node condition to check while the machine is unhealthy * Removing excessive spaces in FAQ ToC links in the "Basics" section were broken due to this. * OOT: Fixes drain failure timeout issues (gardener#548) * OpenStack driver support to create VMs in a given subnet. * Adapt integration tests to handle possibly orphaned resources * Fix the OpenAPI validation of the machine-deployment crd * Reduced default drain timeout to 2hours * Bugfix: maxEvictRetries derived from drainTimeout * OOT: Enqueue machine only when conditions change * Split retry into Short Medium & Long periods * Delete the orphan resources * Backoff on machine creation/deletion faliures. - Introdcued CrashLoopBackOff on machine creation failure * Use listers to get the machine-object during reconciliation * Allow migration to continue when machineClass with same name as ProviderMachineClass is found (gardener#559) * Release v0.35.0 * Prepare Next Dev Cycle v0.36.0-dev * Fix Azure machine deletion if resource group is gone * Add FAQ for paused field * Set Machine Phase to Terminating & make drain calculations based on deletionTimestamp (gardener#564) * Fixes issues with machines being force drained The machines were being force drained during race conditions due to PR gardener#492. This commit fixes that by - Make the drain calculation based on deletion timestamp - Reverted logic from PR gardener#492 to first set machine Termination phase * Update pkg/util/time/time_test.go Fixed typo Co-authored-by: Hardik Dodiya <hardik.dodiya@sap.com> * Update docker images to use latest gcr copy - Updated from golang:1.13.5 to eu.gcr.io/gardener-project/3rd/golang:1.15.5 - Updated from alpine:3.11.2 to eu.gcr.io/gardener-project/3rd/alpine:3.12.1 * Update docs/FAQ.md Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com> * Prevent panic when machine template hash length is < 5 Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * In-tree drivers work with credentials data map They are no longer working with the whole secret because they don't need it. All of them are evaluating the data map only. * Introduce `.spec.credentialsSecretRef` for in-tree machine classes * Introduce `.spec.credentialsSecretRef` for out-of-tree machine class * Support Gardener credentials data keys for Alicloud, AWS, Azure, GCP * bump aws sdk version to v1.23.13 * Migration note for OOT providers (gardener#581) * Updated Readme.md * Release v0.36.0 * Prepare Next Dev Cycle v0.37.0-dev * Update pull_request_template.md (gardener#582) Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * Correcting the variable substitution * docforge manifest (gardener#587) * Check for misconfigured PDBs on Node drain and set proper error description Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * Fix for issue gardener#583 with UT * Release v0.37.0 * Prepare next Dev Cycle v0.38.0-dev * add component-descriptor-trait to head-update job * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.12.0 * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.10.0 * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.11.0 * Run update before fetching on CI image (gardener#596) * Improved NIC creation and deletion logic - NIC creation now, adopts any existing NICs with matching name - NIC deletion confirms deletion by performing GET on deletion - Improved creation logs to give more details - Revendored additional libraries * Release v0.38.0 * Prepare next Dev Cycle v0.39.0-dev * Updated links to various MCM OOT providers * Fixed minor typo * Updated link for metal stack * skip drain readOnlyFileSystem logic and test case added (gardener#605) Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> * Improved log details to include node name and provider ID (gardener#607) Co-authored-by: Prashanth <prashanth@sap.com> * Fixed formatting directive error * Fix panic when secretRef cannot be found (gardener#609) It would assign nil to secretRef, and this would panic when trying to log out the original namespace/name. * Fixes issue adding on finalizers on existing mach (gardener#611) * Release v0.39.0 * Feature openstack volume type & dualstack customs Fix podNetworkCidrs * add openstack volumeType for machine Co-authored-by: Maximilian Geberl <maximilian.geberl@stackit.de> updated VERSION after rebase updated driver_openstack.go changed order of applied services added allowed address pairs Change make to einfachnuralex Split podnetwork and run update port n times changed version and repository added more v6 stuff * VERSION v0.39.0-ske-1 Co-authored-by: gardener-robot-ci-3 <gardener.ci.user3@gmail.com> Co-authored-by: ialidzhikov <i.alidjikov@gmail.com> Co-authored-by: Hardik Dodiya <hardik.dodiya@sap.com> Co-authored-by: Konstantinos Angelopoulos <konstantinos.angelopoulos@sap.com> Co-authored-by: Andrey Klimentyev <andrey.klimentyev@flant.com> Co-authored-by: prashanth26 <prashanth@sap.com> Co-authored-by: dkistner <dominickistner@yahoo.de> Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> Co-authored-by: Anthony Comtois <anthony.comtois@sky.uk> Co-authored-by: Dmitry Shurupov <dmitry.shurupov@flant.com> Co-authored-by: Thomas Buchner <thomas.buchner@sap.com> Co-authored-by: Kistner, Dominic <dominic.kistner@sap.com> Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> Co-authored-by: 郑佳金 <zhengjiajin@pingcap.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com> Co-authored-by: Samarth Deyagond <deyagondsamarth@gmail.com> Co-authored-by: Georgi Pavlov <georgi.pavlov@sap.com> Co-authored-by: Andreas Burger <andreas.burger@sap.com> Co-authored-by: gardener-robot-ci-1 <gardener.ci.user@gmail.com> Co-authored-by: Himanshu Sharma <79965161+himanshu-kun@users.noreply.github.com> Co-authored-by: James Ravn <james@r-vn.org> Co-authored-by: Manuel Ganter <manuel.ganter@hotmail.de>

himanshu-kun requested a review from a team as a code owner May 10, 2021 08:24

gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 10, 2021

AxiomSamarth reviewed May 10, 2021

View reviewed changes

pkg/util/provider/machinecontroller/machine_util.go Outdated Show resolved Hide resolved

AxiomSamarth approved these changes May 10, 2021

View reviewed changes

prashanth26 reviewed May 10, 2021

View reviewed changes

pkg/util/provider/machinecontroller/machine_util.go Show resolved Hide resolved

pkg/util/provider/machinecontroller/machine_util.go Outdated Show resolved Hide resolved

improved logging

239a0a2

print logic for nodeName and providerID with machineName at key places added

himanshu-kun force-pushed the log-improve-1 branch from b9abb6c to 239a0a2 Compare May 12, 2021 09:49

gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 12, 2021

himanshu-kun commented May 12, 2021

View reviewed changes

pkg/util/provider/machinecontroller/machine_util.go Show resolved Hide resolved

prashanth26 approved these changes May 12, 2021

View reviewed changes

pkg/util/provider/machinecontroller/machine.go Outdated Show resolved Hide resolved

pkg/util/provider/machinecontroller/machine_util.go Outdated Show resolved Hide resolved

pkg/util/provider/machinecontroller/machine_util.go Show resolved Hide resolved

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 12, 2021

himanshu-kun and others added 2 commits May 12, 2021 18:18

Update pkg/util/provider/machinecontroller/machine.go

76e3e98

Co-authored-by: Prashanth <prashanth@sap.com>

Update pkg/util/provider/machinecontroller/machine_util.go

b40173b

Co-authored-by: Prashanth <prashanth@sap.com>

prashanth26 changed the title ~~improved logging~~ Improved log details to include node name and provider ID May 13, 2021

prashanth26 merged commit f81374f into gardener:master May 13, 2021

himanshu-kun deleted the log-improve-1 branch June 1, 2021 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved log details to include node name and provider ID #607

Improved log details to include node name and provider ID #607

himanshu-kun commented May 10, 2021 •

edited by prashanth26

gardener-robot commented May 10, 2021

gardener-robot-ci-1 commented May 10, 2021

prashanth26 left a comment

himanshu-kun left a comment

prashanth26 left a comment

Improved log details to include node name and provider ID #607

Improved log details to include node name and provider ID #607

Conversation

himanshu-kun commented May 10, 2021 • edited by prashanth26

gardener-robot commented May 10, 2021

gardener-robot-ci-1 commented May 10, 2021

prashanth26 left a comment

Choose a reason for hiding this comment

himanshu-kun left a comment

Choose a reason for hiding this comment

prashanth26 left a comment

Choose a reason for hiding this comment

himanshu-kun commented May 10, 2021 •

edited by prashanth26