Fix panic when secretRef cannot be found #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would assign nil to secretRef, and this would panic when trying to log out the original namespace/name.
|
@jsravn Thank you for your contribution. |
|
|
gardener-robot
added
needs/review
|
Thank you @jsravn for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
prashanth26
reviewed
May 17, 2021
There was a problem hiding this comment.
First look I got confused on how this change helps. Later got it.
/lgtm
/invite @AxiomSamarth
| @@ -556,12 +556,12 @@ func (c *controller) getSecretData(machineClassName string, secretRefs ...*v1.Se | |||
| continue | |||
| } | |||
|
|
|||
| secretRef, err := c.getSecret(secretRef, machineClassName) | |||
| secret, err := c.getSecret(secretRef, machineClassName) | |||
| if err != nil { | |||
| klog.V(2).Infof("Secret reference %s/%s not found", secretRef.Namespace, secretRef.Name) | |||
There was a problem hiding this comment.
Without this change, this error case log panics. Okay.
|
/ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
einfachnuralex
added a commit
to stackitcloud/machine-controller-manager
that referenced
this pull request
Aug 20, 2021
* Prepare Next Dev Cycle v0.35.0-dev * Wait also for CSI PVs during serial eviction Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * add servergroup option * [azure] Verify tags Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com> * Allow deletion of machines where modify instance fails on deletion * [OOT] Re-enabled support for bootstrap token injection Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com> * Azure MachineSet: VM ScaleSet or AvailabilitySet Add generic MachineSet configuration in AzureMachineClass. The machineSet field can be used to configure either a VMO or an AvailabilitySet for a MachineClass. The availabilitySets field will be kept for a while but is now deprecated in favour of the machineset field. The Azure compute sdk is also updated to support VMSS/VMO. * Introduce constant backoff while enqueuing machine objects on creation and deletion failures Co-authored-by: Prashanth <prashanth@sap.com> * Bugfix: Finalizers are added by default on MC * Added event handlers for MachCls Fixed minor typo * Removed multiple machineClass adds when pointing to same class.kind * Fix typo in documentation The documentation was pointing to the wrong branch. This change fixes it. * Improve documentation with FAQ Co-authored-by: Prashanth <prashanth@sap.com> Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> * Enable NetworkUnavailable as node condition for machine health (gardener#543) Add NetworkUnavailable as node condition to check while the machine is unhealthy * Removing excessive spaces in FAQ ToC links in the "Basics" section were broken due to this. * OOT: Fixes drain failure timeout issues (gardener#548) * OpenStack driver support to create VMs in a given subnet. * Adapt integration tests to handle possibly orphaned resources * Fix the OpenAPI validation of the machine-deployment crd * Reduced default drain timeout to 2hours * Bugfix: maxEvictRetries derived from drainTimeout * OOT: Enqueue machine only when conditions change * Split retry into Short Medium & Long periods * Delete the orphan resources * Backoff on machine creation/deletion faliures. - Introdcued CrashLoopBackOff on machine creation failure * Use listers to get the machine-object during reconciliation * Allow migration to continue when machineClass with same name as ProviderMachineClass is found (gardener#559) * Release v0.35.0 * Prepare Next Dev Cycle v0.36.0-dev * Fix Azure machine deletion if resource group is gone * Add FAQ for paused field * Set Machine Phase to Terminating & make drain calculations based on deletionTimestamp (gardener#564) * Fixes issues with machines being force drained The machines were being force drained during race conditions due to PR gardener#492. This commit fixes that by - Make the drain calculation based on deletion timestamp - Reverted logic from PR gardener#492 to first set machine Termination phase * Update pkg/util/time/time_test.go Fixed typo Co-authored-by: Hardik Dodiya <hardik.dodiya@sap.com> * Update docker images to use latest gcr copy - Updated from golang:1.13.5 to eu.gcr.io/gardener-project/3rd/golang:1.15.5 - Updated from alpine:3.11.2 to eu.gcr.io/gardener-project/3rd/alpine:3.12.1 * Update docs/FAQ.md Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com> * Prevent panic when machine template hash length is < 5 Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * In-tree drivers work with credentials data map They are no longer working with the whole secret because they don't need it. All of them are evaluating the data map only. * Introduce `.spec.credentialsSecretRef` for in-tree machine classes * Introduce `.spec.credentialsSecretRef` for out-of-tree machine class * Support Gardener credentials data keys for Alicloud, AWS, Azure, GCP * bump aws sdk version to v1.23.13 * Migration note for OOT providers (gardener#581) * Updated Readme.md * Release v0.36.0 * Prepare Next Dev Cycle v0.37.0-dev * Update pull_request_template.md (gardener#582) Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * Correcting the variable substitution * docforge manifest (gardener#587) * Check for misconfigured PDBs on Node drain and set proper error description Signed-off-by: ialidzhikov <i.alidjikov@gmail.com> * Fix for issue gardener#583 with UT * Release v0.37.0 * Prepare next Dev Cycle v0.38.0-dev * add component-descriptor-trait to head-update job * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.12.0 * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.10.0 * Update eu.gcr.io/gardener-project/cc/job-image-golang to 0.11.0 * Run update before fetching on CI image (gardener#596) * Improved NIC creation and deletion logic - NIC creation now, adopts any existing NICs with matching name - NIC deletion confirms deletion by performing GET on deletion - Improved creation logs to give more details - Revendored additional libraries * Release v0.38.0 * Prepare next Dev Cycle v0.39.0-dev * Updated links to various MCM OOT providers * Fixed minor typo * Updated link for metal stack * skip drain readOnlyFileSystem logic and test case added (gardener#605) Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> * Improved log details to include node name and provider ID (gardener#607) Co-authored-by: Prashanth <prashanth@sap.com> * Fixed formatting directive error * Fix panic when secretRef cannot be found (gardener#609) It would assign nil to secretRef, and this would panic when trying to log out the original namespace/name. * Fixes issue adding on finalizers on existing mach (gardener#611) * Release v0.39.0 * Feature openstack volume type & dualstack customs Fix podNetworkCidrs * add openstack volumeType for machine Co-authored-by: Maximilian Geberl <maximilian.geberl@stackit.de> updated VERSION after rebase updated driver_openstack.go changed order of applied services added allowed address pairs Change make to einfachnuralex Split podnetwork and run update port n times changed version and repository added more v6 stuff * VERSION v0.39.0-ske-1 Co-authored-by: gardener-robot-ci-3 <gardener.ci.user3@gmail.com> Co-authored-by: ialidzhikov <i.alidjikov@gmail.com> Co-authored-by: Hardik Dodiya <hardik.dodiya@sap.com> Co-authored-by: Konstantinos Angelopoulos <konstantinos.angelopoulos@sap.com> Co-authored-by: Andrey Klimentyev <andrey.klimentyev@flant.com> Co-authored-by: prashanth26 <prashanth@sap.com> Co-authored-by: dkistner <dominickistner@yahoo.de> Co-authored-by: Samarth Deyagond <samarth.deyagond@sap.com> Co-authored-by: Anthony Comtois <anthony.comtois@sky.uk> Co-authored-by: Dmitry Shurupov <dmitry.shurupov@flant.com> Co-authored-by: Thomas Buchner <thomas.buchner@sap.com> Co-authored-by: Kistner, Dominic <dominic.kistner@sap.com> Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> Co-authored-by: 郑佳金 <zhengjiajin@pingcap.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com> Co-authored-by: Samarth Deyagond <deyagondsamarth@gmail.com> Co-authored-by: Georgi Pavlov <georgi.pavlov@sap.com> Co-authored-by: Andreas Burger <andreas.burger@sap.com> Co-authored-by: gardener-robot-ci-1 <gardener.ci.user@gmail.com> Co-authored-by: Himanshu Sharma <79965161+himanshu-kun@users.noreply.github.com> Co-authored-by: James Ravn <james@r-vn.org> Co-authored-by: Manuel Ganter <manuel.ganter@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would assign nil to secretRef, and this would panic when trying
to log out the original namespace/name.