Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform to 0.14.11 #106

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Upgrade terraform to 0.14.11 #106

merged 1 commit into from
Dec 20, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Nov 5, 2021 •
edited

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Upgrades terraform to 0.14.11. This is the second step of upgrading to 0.15 in order to fix gardener/gardener/issues/4838.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • I ran successfully make test-e2e and make docker-images locally.
  • I also ran successfully make start and make start COMMAND=destroy with a valid AWS configuration for one of my test shoots.
  • I also ran successfully make start and make start COMMAND=destroy with a valid AWS configuration for one of my test shoots and an old state created with terraformer 0.12.31.
  • For the provider validation status, see the comment below.

Release note:

terraform has been upgraded to 0.14.11

@stoyanr stoyanr requested a review from a team as a code owner November 5, 2021 11:56
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 5, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2021
This was referenced Nov 5, 2021
Closed
Closed
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 5, 2021 •
edited

AWS (see gardener/gardener-extension-provider-aws/pull/441):

  • reconciliation and deletion of existing Infrastructure (created with 0.12.31)
  • creation and deletion of new Infrastructure (single zone, new vpc)
  • creation and deletion of new Infrastructure (single zone, existing vpc)
  • creation and deletion of new Infrastructure (multiple zones, new vpc)
  • creation and deletion of new Infrastructure (multiple zone, existing vpc)
  • gardener-extension-provider-aws Infrastructure integration test

GCP (see gardener/gardener-extension-provider-gcp/pull/346):

  • reconciliation and deletion of existing Infrastructure (created with 0.12.31)
  • creation and deletion of new Infrastructure (single zone, new vpc)
  • creation and deletion of new Infrastructure (single zone, existing vpc)
  • gardener-extension-provider-gcp Infrastructure integration test

Azure (see gardener/gardener-extension-provider-azure/pull/392):

  • reconciliation and deletion of existing Infrastructure (created with 0.12.31)
  • creation and deletion of new Infrastructure

Alicloud (see gardener/gardener-extension-provider-alicloud/pull/380):

  • reconciliation and deletion of existing Infrastructure (created with 0.12.31)
  • creation and deletion of new Infrastructure

Openstack (see gardener/gardener-extension-provider-openstack#351):

  • reconciliation and deletion of existing Infrastructure (created with 0.12.31)
  • creation and deletion of new Infrastructure

@stoyanr stoyanr marked this pull request as draft November 5, 2021 12:57
This was referenced Nov 5, 2021
Closed
Closed
Closed
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 5, 2021

/invite @ialidzhikov

This was referenced Nov 5, 2021
Merged
Closed
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
@stoyanr stoyanr marked this pull request as ready for review November 19, 2021 12:09
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
@stoyanr stoyanr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
@stoyanr stoyanr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2021
ialidzhikov
ialidzhikov approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 20, 2021
@stoyanr stoyanr merged commit 7f1cf44 into master Dec 20, 2021
@stoyanr stoyanr deleted the upgrade-terraform-to-0.14.11 branch December 20, 2021 13:39
This was referenced Dec 20, 2021
Closed
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly classify infra dependencies that show up as "at least one terraformer pod still exists" errors
6 participants
@stoyanr @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot