Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraformer-v2] Add Pod e2e test #51

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Nov 12, 2020

/area quality
/kind test

What this PR does / why we need it:
This PR adds an e2e test, that is executed by the test-machinery. It functions similarly to some infrastructure integration tests in our provider extensions.

It uses an existing cluster (pointed to by the KUBECONFIG env var) and deploys a terraformer apply Pod, that will create some lightweight resource (ec2 keypair) on AWS.
The test validates, that the resource was created on AWS using the AWS go-sdk and that the state ConfigMap has been updated accordingly.
After that, the test deploys a terraformer destroy Pod and validates again the changes on AWS and the state ConfigMap.

Which issue(s) this PR fixes:
Fixes #10

Special notes for your reviewer:
/invite @gardener/test-infra-maintainers

Release note:

You can now run a small e2e test, that creates some lightweight resource on AWS via terraform, by executing `make test-e2e`.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/test Test needs/review Needs review labels Nov 12, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 12, 2020
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 12, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@timebertt
Copy link
Member Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review November 12, 2020 15:14
@gardener-robot gardener-robot requested a review from a team as a code owner November 12, 2020 15:14
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@timebertt
Copy link
Member Author

/test-single

@testmachinery
Copy link

testmachinery bot commented Nov 12, 2020

Testrun: e2e-6g7kp
Workflow: e2e-6g7kp-wf
Phase: Failed

+--------------+--------------+--------+----------+
|     NAME     |     STEP     | PHASE  | DURATION |
+--------------+--------------+--------+----------+
| pod-e2e-test | pod-e2e-test | Failed | 1m55s    |
+--------------+--------------+--------+----------+

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added needs/changes Needs (more) changes and removed needs/review Needs review labels Nov 12, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Nov 12, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2020
@testmachinery
Copy link

testmachinery bot commented Nov 18, 2020

Testrun: e2e-rjzfg
Workflow: e2e-rjzfg-wf
Phase: Failed

+--------------+--------------+--------+----------+
|     NAME     |     STEP     | PHASE  | DURATION |
+--------------+--------------+--------+----------+
| pod-e2e-test | pod-e2e-test | Failed | 21m44s   |
+--------------+--------------+--------+----------+

@schrodit
Copy link

/test

@testmachinery
Copy link

testmachinery bot commented Nov 19, 2020

Testrun: e2e-xqsbk
Workflow: e2e-xqsbk-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m58s    |
+--------------+--------------+-----------+----------+

@timebertt
Copy link
Member Author

Thank you very much, @schrodit! 🎉

.ci/test-e2e.sh Show resolved Hide resolved
.test-defs/pod-e2e.yaml Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Nov 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2020
@timebertt
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 19, 2020

Testrun: e2e-xxv6r
Workflow: e2e-xxv6r-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m29s    |
+--------------+--------------+-----------+----------+

.ci/test-e2e.sh Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2020
@timebertt
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 19, 2020

Testrun: e2e-ftrbd
Workflow: e2e-ftrbd-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 3m48s    |
+--------------+--------------+-----------+----------+

@timebertt timebertt merged commit 47134e7 into gardener:terraformer-v2 Nov 20, 2020
@timebertt timebertt deleted the enh/pod-e2e-test branch November 20, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/test Test needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants