Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalizer to the user secret and configmaps #65

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Add finalizer to the user secret and configmaps #65

merged 1 commit into from
Jan 7, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area quality
/area robustness
/kind enhancement
/priority normal

What this PR does / why we need it:
Ensures that the configmaps and secrets used by the terraformer have a finalizer as long as a successful destroy is executed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The configmaps and secrets used to contain terraform configuration, state and variables are now protected with a finalizer against accidental deletion.

@vpnachev vpnachev requested a review from a team as a code owner December 10, 2020 16:33
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension priority/normal labels Dec 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 10, 2020
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 10, 2020
@timebertt timebertt self-assigned this Dec 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 11, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 11, 2020
@rfranzke
Copy link
Member

/test

@testmachinery
Copy link

testmachinery bot commented Dec 14, 2020 •
edited

Testrun: e2e-5j2f4
Workflow: e2e-5j2f4-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m27s    |
+--------------+--------------+-----------+----------+

rfranzke
rfranzke previously approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 14, 2020
timebertt
timebertt suggested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some first feedback inline.
I still have to go through the tests.

pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/terraformer/terraformer.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added needs/changes Needs (more) changes and removed reviewed/lgtm Has approval for merging labels Dec 14, 2020
timebertt
timebertt reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final minor remarks.

test/utils/objects.go Outdated Show resolved Hide resolved
pkg/terraformer/types.go Outdated Show resolved Hide resolved
test/utils/objects.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2020
@vpnachev
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Dec 18, 2020 •
edited

Testrun: e2e-vs8q5
Workflow: e2e-vs8q5-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m41s    |
+--------------+--------------+-----------+----------+

timebertt
timebertt reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor comment :)
Otherwise lgtm.

pkg/terraformer/terraformer.go Show resolved Hide resolved
@rfranzke rfranzke added the status/author-action Issue requires issue author action label Dec 28, 2020
@gardener-robot
Copy link

@vpnachev The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2021
@gardener-robot gardener-robot removed the status/author-action Issue requires issue author action label Jan 4, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2021
@vpnachev
Copy link
Member Author

vpnachev commented Jan 4, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Jan 4, 2021 •
edited

Testrun: e2e-jrxxj
Workflow: e2e-jrxxj-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m32s    |
+--------------+--------------+-----------+----------+

timebertt
timebertt approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you very much, @vpnachev!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/changes Needs (more) changes and removed needs/changes Needs (more) changes needs/review Needs review reviewed/lgtm Has approval for merging labels Jan 7, 2021
@timebertt timebertt merged commit 6c101f2 into gardener:master Jan 7, 2021
@vpnachev vpnachev deleted the finalizers branch January 15, 2021 20:50
@vpnachev vpnachev mentioned this pull request Jan 15, 2021
Merged
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@rfranzke rfranzke rfranzke left review comments

Assignees

@vpnachev vpnachev

@timebertt timebertt

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension kind/test Test needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vpnachev @rfranzke @timebertt @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3