Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove curl from Terraformer image #69

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Remove curl from Terraformer image #69

merged 1 commit into from
Feb 5, 2021

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Feb 5, 2021

How to categorize this PR?

/area security
/kind cleanup
/priority normal

What this PR does / why we need it:
This PR removes the curl package installation from the Dockerfile.

Special notes for your reviewer:
/cc @ThormaehlenFred

Release note:

Curl has been removed from the Terraformer image.

@timuthy timuthy requested a review from a team as a code owner February 5, 2021 12:34
@gardener-robot gardener-robot added area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 5, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 5, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2021
@timebertt
Copy link
Member

/test

@testmachinery
Copy link

testmachinery bot commented Feb 5, 2021 •
edited

Testrun: e2e-dm6rq
Workflow: e2e-dm6rq-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m17s    |
+--------------+--------------+-----------+----------+

rfranzke
rfranzke approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 5, 2021
@timuthy timuthy merged commit e3f81da into master Feb 5, 2021
@timuthy timuthy deleted the enhancement/build branch February 5, 2021 14:06
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timuthy @timebertt @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot