Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch packet to equinix metal #73

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Feb 19, 2021

Signed-off-by: Avi Deitcher avi@deitcher.net

How to categorize this PR?

/area control-plane
/kind enhancement
/priority normal

What this PR does / why we need it:

  • Bump the packet provider to the equinix metal provider
  • Provide a pre-bundle.sh option, so that can pre-download if needed.

Special notes for your reviewer:

Release note:

Provides support for the Equinix Metal provider, which replaces the Packet one

@deitch deitch requested a review from a team as a code owner February 19, 2021 11:43
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension priority/normal labels Feb 19, 2021
@gardener-robot
Copy link

@deitch Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 19, 2021
@gardener-robot-ci-1
Copy link
Contributor

Thank you @deitch for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

build/all/pre-bundle.sh Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2021
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 19, 2021
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
Shouldn't build/equinixmetal/TF_VERSION be bumped to v0.13.x now or am I missing something?

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
@deitch
Copy link
Contributor Author

deitch commented Feb 19, 2021

Shouldn't build/equinixmetal/TF_VERSION be bumped to v0.13.x now or am I missing something?

I thought I did. Huh. OK, repushing.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch
Copy link
Contributor Author

deitch commented Feb 19, 2021

Ah, it is a symlink! Ok, broke the link and gave it a specific version. Done.

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, much easier now with the provider-specific tf version :)
Thank you!
/lgtm
/ok-to-test

@@ -42,12 +42,12 @@ terraformer:
target: terraformer
build_args:
PROVIDER: openstack
terraformer-packet:
terraformer-equinixmetal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: the build for this PR will probably fail now because of the renaming, as the pipeline configs on the source branch are not considered for overwriting config on the base branch.
We will merge it nevertheless, on master it should build then.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Feb 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
@rfranzke rfranzke merged commit e3dedeb into gardener:master Feb 19, 2021
@timebertt
Copy link
Member

Hmm, the build on master actually didn't work: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/terraformer-master/jobs/master-head-update-job/builds/21#L602fba49:182
@deitch can you resolve the issue in a follow-up PR?
You can test the build locally by running make docker-image PROVIDER=equinixmetal.

@deitch deitch deleted the equinix-metal branch February 21, 2021 09:18
@deitch
Copy link
Contributor Author

deitch commented Feb 21, 2021

@timebertt wrote:

Hmm, the build on master actually didn't work: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/terraformer-master/jobs/master-head-update-job/builds/21#L602fba49:182

I cannot see that, get a 401. Can you paste some of the output here?

You can test the build locally by running make docker-image PROVIDER=equinixmetal.

I did. It ran fine to the end, created the image and exited 0. I can run the image without issue.

This was referenced Feb 22, 2021
@timebertt
Copy link
Member

I cannot see that, get a 401. Can you paste some of the output here?

😞
Can we finally make build logs for public repos public by default? @AndreasBurger @ccwienk

Opened #75 for now.

@timebertt
Copy link
Member

Anyways, the output was containing this:

Removing intermediate container 57de3aa4585c
 ---> b5745e68fec7
Step 18/24 : WORKDIR /
 ---> Running in e1ca68da4c3d
Removing intermediate container e1ca68da4c3d
 ---> a240a9b25c7b
Step 19/24 : ENV TF_DEV=true
 ---> Running in 2ac8c50a6679
Removing intermediate container 2ac8c50a6679
 ---> ba595562c1aa
Step 20/24 : ENV TF_RELEASE=true
 ---> Running in e0db15e06740
Removing intermediate container e0db15e06740
 ---> 39e89dcd2d51
Step 21/24 : COPY --from=builder /go/bin/terraformer /
 ---> 1134739c75a7
Step 22/24 : COPY --from=terraform-base /tmp/terraformer/terraform /bin/terraform
 ---> ec6f6cb29dd9
Step 23/24 : COPY --from=terraform-base /tmp/terraformer/terraform-provider* /terraform-providers/
COPY failed: no source files were specified

I think, #76 should fix it :)

@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants