Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defragment compos when entries are moved out #63

Open
psenough opened this issue Sep 7, 2022 · 1 comment
Open

Defragment compos when entries are moved out #63

psenough opened this issue Sep 7, 2022 · 1 comment

Comments

@psenough
Copy link

psenough commented Sep 7, 2022

If you select the option to move a prod to another compo and the prod is not the last entry of the compo, it will leave a void in the entry order of the original compo (highlighted in red but hard to recover from), the dragentries plugin will then start throwing php errors if you try to reorder things. Only way to recover seems to be to either edit the database directly or to move out all the remaining red marked entries from the compo one by one and move them back in.

Would be nice if moving the entry would also update the order of all prods; or only allow to move an entry when it's already the last entry of the compo; or dragentries plugin to override those errors automatically afterwards to become an easy fix.

@Gargaj
Copy link
Owner

Gargaj commented Sep 7, 2022

The error is fixed in 21ba967 - but yes, compos should defragment when entries get moved out.

@Gargaj Gargaj changed the title Moving entry to another compo bug Defragment compos when entries are moved out Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants