Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StickyScrollUp sticks to the bottom of Sticky component feasible? #31

Open
trompx opened this issue Nov 20, 2020 · 1 comment
Open

Comments

@trompx
Copy link

trompx commented Nov 20, 2020

Hello @garthenweb,

I tested your ibrary but couldn't do what I had in mind and I don't know if it supports this usecase.
I'd like to have a sticky header (same behavior that css sticky -> so your Sticky component) and have a secondary bar with StickyScrollUp component but which doesn't push the Sticky components to the bottom on scroll up but instead scroll until it sticks to the bottom of the currently active Sticky component (and if no Sticky component is on screen), scroll until it sticks to the top of the page.
Is that supported ?

I could have the behavior I want by only using a StickyScrollUp components and a css sticky header but I'd need to set a props so the StickyScrollUp component scroll untils it reaches the bottom of my header. We could maybe add a props to set the sticky distance from the top on scroll up.

Also I noticed that on the demo page, when you scroll enough to make the StickyScrollUp disappear, the first scroll event doesn't make the StickyScrollUp to appear but it appears only on the second scroll.

@garthenweb
Copy link
Owner

@trompx Even though I am not 100% sure if I understand you completely, I can tell there is no support to stick content to the bottom of the page as of now. I am also not sure how much effort this would be to implement, could introduce quite a few edge cases. But feel free to create a PR to implement this feature, so we can discuss if the overhead it would add is worse to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants