Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDP was warning when dumping refs to unopened or closed file handles #29

Merged
merged 1 commit into from
Jul 13, 2012

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Jul 12, 2012

This just suppresses two warnings that don't otherwise indicate problems. In the future maybe check the "opened" flag? I'm not entirely sure one would distinguish between "closed" and "unopened" nor if one would want to.

garu added a commit that referenced this pull request Jul 13, 2012
DDP was warning when dumping refs to unopened or closed file handles
@garu garu merged commit 4cb9431 into garu:master Jul 13, 2012
@garu
Copy link
Owner

garu commented Jul 13, 2012

Brilliant, thanks! Also, not only the open/closed status but also the seek position could be a good thing to show, maybe even a flag to let you see the surrounding area within the file. If not in DDP's core then at least as an external filter. What do you think?

@iarna
Copy link
Contributor Author

iarna commented Jul 13, 2012

Good ideas, all of them, although I'm not particularly motivated to look into them personally as I'm not in the habit of dumping file handles. I actually only encountered these warnings when I mangled a glob when writing the FORMAT test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants