Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixing whitespaces errors #51
I've used script
Here is the list of rules that Test::Whitespaces uses:
referenced this pull request
Jul 14, 2013
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I'm glad that you have Travic CI conected to this repo. Because of travis I found out that after this change one test fails. I've used Test::Differences to find out the details:
I found out that this behavior goes from this lines in lib/Data/Printer.pm:
But it change
There are 3 ways of solving this problem:
My idea that the variant 3 should be implemented (it is the hardiest one, but it is the most correct way of solving this issue).
What do you think?
Nice! Actually, while I agree with you that variant 3 should be implemented, the issue I think is mostly because the regex being tested begins with a newline, and this is the only reason why the space becomes irrelevant. Considering that "relevant trailing whitespace is evil" I will fiddle with the expected string so the tests (and #52) remain valid, without needing the overhead of changing p() just because we want to remove trailing whitespace :)
Thanks again for the patch! (and for all the others)