Addressing some comments from PR #2071 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VoF Interface tracking
avoid warning in gravity point postprocessor
update parameters
…hy_point_wise_vector Output dynamic topography as point-wise vector
…_vector Write geoid output point-wise
…erpolation Slightly improve accuracy of particle interpolation for active particles in time-varying flow.
…wise_vector Add a higher resolution heat flux visualization postprocessor
…s_to_cmake add cmake compile commands output.
It turns out that we do not support 2.8.8 as advertised, but that we need 2.8.12 (confirmed working). While here, fix a few weird looking CMakeLists.txt files (missing headers)
Minor textual updates.
set minimum required cmake version
Avoid a deprecated symbol.
update copyright years
…rticle_code Remove particle code that is now in deal.II
Fix issue 2315
Increase GMRES restart length for advection solver
…lastic_tests Add missing test results
…icle_code Remove some more ifdefs
…update to work with dealii v9.0.1 and ASPECT 2.1.0
…and relevant parameter section name changes as well.
Mesh deformation dn
Mesh deformation dn
|
Since we now use your pull request to master as the way forward let me close this one. |
gassmoeller
pushed a commit
that referenced
this pull request
Apr 24, 2023
Only assert if parameter is read. Fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Rene,
In preparation for the hackathon, I wanted to restart discussion on PR geodynamics#2071 and address some of the comments. So far I've updated this branch so it compiles with the latest ASPECT and dealii v9.0.1, changed the handler name from FreeSurfaceHandler to MeshDeformationHandler, and changed some of the parameter file names. I had some issues running your example test, but from a quick test on using the function and free surface individually and combined, they seem to still work as intended.