Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing parts of HDF5 #23

Closed
julien-nc opened this issue May 29, 2018 · 3 comments
Closed

missing parts of HDF5 #23

julien-nc opened this issue May 29, 2018 · 3 comments

Comments

@julien-nc
Copy link

I'm happily using GATB v1.4.1 for LoRDEC but i'm now annoyed because i can't find H5File::isHdf5 function in included hdf5 lib.

I fought hard to include the libhdf5 from my system (Ubuntu 18.04) but then there's a warning at execution :

Warning! ***HDF5 library version mismatched error***                                                                                                                                                           
The HDF5 header files used to compile this application do not match                                                                                                                                            
the version used by the HDF5 library to which this application is linked.

and i get a (core dumped).

  • Would it be possible to include the whole libhdf5 in GATB to provide H5File::isHdf5 and avoid having to include another libhdf5 ? (simplest solution IMHO)
  • If not, is there an easy way to tell GATB to use my system's libhdf5 ?
  • If so, will GATB compile with libhdf5 1.10.0 instead of 1.8.18 ?
@rchikhi
Copy link
Member

rchikhi commented May 29, 2018

Hi,
Unfortunately we do not officially support a system's libhdf5, for the reason that not every GATB user has root access on his/her system, and therefore installing libhdf5 would be an extra hassle.
My understanding is that isHdf5() function checks whether a file is a valid HDF5 file. Why not just check if the file name ends with ".h5"?
If there is a good reason not to do that, we will upgrade/complete libhdf5 in GATB to a newer version.
Best,
Rayan

@julien-nc
Copy link
Author

Thanks for your quick answer !

The reason why i want to check hdf5 files validity is that, when a De Bruijn graph creation is interrupted, the created file is invalid and makes hdf5 crash when my program crash reads it. Some LoRDEC users are experiencing this kind of problem and i would like to prevent it by deleting any invalid hdf5 files and creating a new one.

HDF5 lib is not throwing an exception that i could catch to handle invalid hdf5 file reading.

By the way, i don't mind if the HDF5lib version stays old, i just would like it to include more 😉

@rchikhi
Copy link
Member

rchikhi commented May 6, 2019

hi @eneiluj,

In an effort to not let our issues be unaddressed for more than 1 year, here is a fix :)
I've updated gatb-core to use the latest HDF5 version (1.10.5).
Sorry for the delay, and please let me know if you run into problems with this update.

Rayan

@rchikhi rchikhi closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants