Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress for downloading remote files #10948

Closed
KyleAMathews opened this issue Jan 9, 2019 · 2 comments · Fixed by #10979
Closed

Show progress for downloading remote files #10948

KyleAMathews opened this issue Jan 9, 2019 · 2 comments · Fixed by #10979
Assignees

Comments

@KyleAMathews
Copy link
Contributor

Many plugins rely on createRemoteFileNode from gatsby-source-filesystem to download files from remote systems. E.g. gatsby-source-wordpress downloads all the files from the wordpress instance so you can include them in your site and do data transformations e.g. image thumbnail creation.

This is great but some systems have many files which can take a long time to download. This downloading can cause confusion because the Gatsby bootstrap just stalls out for no apparent reason.

To start improving this, the first thing we need to do is to show a progress bar & current status for downloads.

Related issue about problems this causes with wordpress #6654

@polarathene
Copy link
Contributor

polarathene commented Jan 10, 2019

Also related: #6125

Over 11 minutes on source and transform nodes for me with one of the example projects(gatsby-image that pulls 130MB remote images from unsplash). Before being aware of the large remote content being downloaded I thought the build process had become stuck.

My suggestion in the linked issue was to consider a (sourced_nodes/total_nodes) feedback counter for the step with a timer delay before showing some hints to why the process might be taking long to the developer(especially useful and perhaps easier to implement if knowing the total nodes/remote content in advance is not an easy feature to provide). Linked issue contains some example messages/tips that could cycle.

I have also noted in that example project, that when an image was sourced remotely(at least in that project/unsplash case), if the transfer fails during, no error was raised, instead the build is considered successful and the images that failed will display their partially downloaded contents. Should I raise another issue about that? I'm not quite sure how I could setup a reproducible project to demonstrate or if Gatsby would have anyway to confirm the remote download was successful?

@oorestisime
Copy link
Contributor

I would love to give this a go since i use that api quite often. I am assigning it to myself to avoid double work.

@oorestisime oorestisime self-assigned this Jan 10, 2019
oorestisime added a commit to oorestisime/gatsby that referenced this issue Jan 10, 2019
KyleAMathews pushed a commit that referenced this issue Jan 11, 2019
* [gatsby-source-filesystem] Add progress bar

Fix: #10948

* Change wording on progress bar
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
* [gatsby-source-filesystem] Add progress bar

Fix: gatsbyjs#10948

* Change wording on progress bar
mwfrost pushed a commit to mwfrost/gatsby that referenced this issue Apr 20, 2023
* [gatsby-source-filesystem] Add progress bar

Fix: gatsbyjs#10948

* Change wording on progress bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants