Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Webp in gatsby-remark-images-contentful #11268

Closed
AlbericTrancart opened this issue Jan 24, 2019 · 4 comments
Closed

Enable support for Webp in gatsby-remark-images-contentful #11268

AlbericTrancart opened this issue Jan 24, 2019 · 4 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@AlbericTrancart
Copy link
Contributor

Summary

As of now, gatsby-remark-contentful-images doesn't have a withWebp option like gatsby-remark-images.

Basic example

This config:

{
  resolve: `gatsby-transformer-remark`,
  options: {
    plugins: [
      {
        resolve: `gatsby-remark-images-contentful`,
        options: {
          maxWidth: 1000,
          withWebp: true
        }
      }
    ]
  }
},

Would add srcsets to webp images with a fallback on the classic srcset for unsupported browsers.

Motivation

This could provide a substantial speed improvement on supported browsers.

I volunteer for coding this feature :)

@sidharthachatterjee
Copy link
Contributor

Hey @AlbericTrancart

It's awesome that you went ahead and wrote this out and opened the PR! Just wanted to leave this comment to say thank you.

@gatsbot
Copy link

gatsbot bot commented Feb 18, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 18, 2019
@AlbericTrancart
Copy link
Contributor Author

@gatsbot
Copy link

gatsbot bot commented Mar 10, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Mar 10, 2019
wardpeet added a commit that referenced this issue Mar 11, 2019
## Description

Add a `withWebp` option to include a webp source in parsed images from contentful.

## Related Issues

Addresses #11268.


Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

2 participants