-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-remark-images-contentful): enable webp sources #11273
feat(gatsby-remark-images-contentful): enable webp sources #11273
Conversation
Is there any reason to not just make this the default? Seems like everyone should have webp enabled :-) |
we should enable it by default 👍 |
@KyleAMathews I didn't enabled it by default because it isn't in @wardpeet what kind of structure are you thinking of? Something like this? (I will implement this TODO rightaway if possible 😉 )
|
hey @AlbericTrancart it's super cool that you want to take this on right away but it would be a breaking change so we have to wait for gatsby v3. Also I haven't thought about it yet 😄. The current behaviour is perfect for now. So good job! 💪 |
726b058
to
0715ea7
Compare
Updated! |
@wardpeet this wouldn't be a breaking change actually because it's hidden from the user — nobody's code would break — their sites would just get faster :-) |
@AlbericTrancart the only reason we don't include it by default in gatsby-remark-images is that generating webp thumbnails is a lot more expensive than jpg. So we want people to opt into webp so they realize the cost they're taking on (as not everyone wants to tradeoff longer build times for smaller images). But with a hosted service like Contentful where webp images are generated on demand, it makes a lot more sense to default to webp. |
@KyleAMathews @wardpeet any news on merging this PR? :) |
0715ea7
to
2618b0a
Compare
@wardpeet PR rebased to fix a merge conflict on the README. |
Any update on this? I would love to see the gatsby-remark-images-contentful plugin get some improvements. |
@wardpeet @KyleAMathews ping to merge this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your patience. It looks great, I've added the small TODO.
Holy buckets, @AlbericTrancart — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published in gatsby-remark-images-contentful@2.0.9 |
Description
Add a
withWebp
option to include a webp source in parsed images from contentful.Related Issues
Addresses #11268.