Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom bar during develop build #24630

Closed
MatteoGauthier opened this issue May 29, 2020 · 5 comments
Closed

Bottom bar during develop build #24630

MatteoGauthier opened this issue May 29, 2020 · 5 comments
Labels
topic: cli Related to the Gatsby CLI

Comments

@MatteoGauthier
Copy link

Description

A bottom bar appear during development build
image

Steps to reproduce

yarn develop

Expected result

No bottom bar should be better for user, we cant see the output

Actual result

Result hidden

Environment

  System:
    OS: Windows 10 10.0.18363
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Binaries:
    Node: 12.16.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.21.1 - ~\.yarn\bin\yarn.CMD
    npm: 6.14.4 - C:\Program Files\nodejs\npm.CMD
  Languages:
    Python: 2.7.18 - /c/Python27/python
  Browsers:
    Edge: 44.18362.449.0
  npmPackages:
    gatsby: ^2.21.37 => 2.21.37 
    gatsby-image: ^2.4.4 => 2.4.4 
    gatsby-plugin-manifest: ^2.4.5 => 2.4.5 
    gatsby-plugin-offline: ^3.2.3 => 3.2.3 
    gatsby-plugin-react-helmet: ^3.3.1 => 3.3.1 
    gatsby-plugin-sharp: ^2.6.4 => 2.6.4 
    gatsby-source-filesystem: ^2.3.4 => 2.3.4 
    gatsby-transformer-sharp: ^2.5.2 => 2.5.2 
  npmGlobalPackages:
    gatsby-cli: 2.12.34
@MatteoGauthier MatteoGauthier added the type: bug An issue or pull request relating to a bug in Gatsby label May 29, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 29, 2020
@madalynrose madalynrose added the topic: cli Related to the Gatsby CLI label Jun 1, 2020
@madalynrose
Copy link
Contributor

Hi there @MattixNow! I'm trying to understand the root of your issue. Could you explain what you mean by "bottom bar" and which output you are unable to see? I believe the status bar has always existed and want to make sure I fully understand the bug you are reporting.

@madalynrose madalynrose added status: awaiting author response Additional information has been requested from the author and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 1, 2020
@MatteoGauthier
Copy link
Author

Hey, thanks for your reply !

The bottom bar is this

————————————————————————————————————————————————————————————————————————————————————————
5 pages                              SUCCESS                              gatsby-starter-default

The bottom bar isn't displaying in all of my gatsby project (displayed on the gatsby-starter-default, but not on the gatsby-starter-hello-world). In vscode this output take a lot of space when the integrated terminal is opened (the user have to change the height of the integrated terminal) and the informations which are display are not useful (number of pages, build status, project name) knowing that the information relating to the built is displayed just above.

Finally i think it's not user friendly, it's an accessibility issue

@LekoArts LekoArts removed status: awaiting author response Additional information has been requested from the author type: bug An issue or pull request relating to a bug in Gatsby labels Jun 2, 2020
@LekoArts
Copy link
Contributor

LekoArts commented Jun 2, 2020

The status bar is in our CLI since a year already (#14973) so this is nothing new. It'll display in all projects and so far we haven't heard any complaints.

What are the accessibility issues?

@MatteoGauthier
Copy link
Author

Annotation 2020-06-02 174919
You can see the wide space the bottom bar takes on my screen, this is why i think it's an accessibility issue

@LekoArts
Copy link
Contributor

LekoArts commented Jun 3, 2020

Thanks for the follow-up!

I think it's debatable if the information is useless or not, in our opinion it's useful and something we want to keep. In my terminal it doesn't have the height you're showing so you might check with https://github.com/vadimdemedes/ink if your CLI is having issues displaying the spaces correctly.

However, I found that the develop bar doesn't always show, so I created an issue for that: #24736

Thanks for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

No branches or pull requests

3 participants