Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): structured logging #14973

Merged
merged 160 commits into from
Oct 14, 2019
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jun 20, 2019

This make reporter just dispatch redux actions instead of directly outputting to console.

  • Ink will connect to redux state with react-redux
  • Yurnalist need some hackiness, but hopefully we will be able to get rid of it (especially after dropping node 6)
  • Added barebones json logger (that now just output action objects to stdout):
    Kapture 2019-06-20 at 19 22 17

Notes:

  • removed our current webpack console updates (we actually have 2 separate packages doing that now :S)
  • added initial draft of "stateful messages" - probably will be used mostly for showing/clearing errors:
    Kapture 2019-06-20 at 19 15 22

Fixes #17109

@m-allanson m-allanson removed this from To do in "Snow Leopard" fixes Jul 16, 2019
@m-allanson m-allanson added this to In progress in OSS Roadmap Aug 13, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, mostly just questions

docs/docs/images/disqus-logo.svg Outdated Show resolved Hide resolved
integration-tests/structured-logging/__tests__/logs.js Outdated Show resolved Hide resolved
integration-tests/structured-logging/__tests__/logs.js Outdated Show resolved Hide resolved
integration-tests/structured-logging/__tests__/logs.js Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/commands/develop.js Show resolved Hide resolved
packages/gatsby-cli/src/reporter/index.js Show resolved Hide resolved
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all the hard work and listening to all my comments! I'm so excited to get this merged in! 👏 🥇

@sidharthachatterjee sidharthachatterjee merged commit eafb8c6 into gatsbyjs:master Oct 14, 2019
OSS Roadmap automation moved this from In progress to Done Oct 14, 2019
@sidharthachatterjee sidharthachatterjee deleted the logs-to-redux branch October 14, 2019 07:26
@sidharthachatterjee
Copy link
Contributor

Published in gatsby@2.16.0 and gatsby-cli@2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
OSS Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

Structured logging
5 participants