Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): structured logging #14973

Merged
merged 160 commits into from Oct 14, 2019
Merged

Conversation

@pieh
Copy link
Contributor

pieh commented Jun 20, 2019

This make reporter just dispatch redux actions instead of directly outputting to console.

  • Ink will connect to redux state with react-redux
  • Yurnalist need some hackiness, but hopefully we will be able to get rid of it (especially after dropping node 6)
  • Added barebones json logger (that now just output action objects to stdout):
    Kapture 2019-06-20 at 19 22 17

Notes:

  • removed our current webpack console updates (we actually have 2 separate packages doing that now :S)
  • added initial draft of "stateful messages" - probably will be used mostly for showing/clearing errors:
    Kapture 2019-06-20 at 19 15 22

Fixes #17109

@m-allanson m-allanson removed this from To do in "Snow Leopard" fixes Jul 16, 2019
@m-allanson m-allanson added this to In progress in OSS Roadmap Aug 13, 2019
Copy link
Member

wardpeet left a comment

I left some comments, mostly just questions

docs/docs/images/disqus-logo.svg Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/query/query-compiler.js Outdated Show resolved Hide resolved
packages/gatsby/src/commands/develop.js Show resolved Hide resolved
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@pieh pieh force-pushed the pieh:logs-to-redux branch from 14a4cf7 to 66a62a1 Oct 11, 2019
pieh and others added 2 commits Oct 11, 2019
@sidharthachatterjee sidharthachatterjee force-pushed the pieh:logs-to-redux branch from 4ca6fb4 to 4014e46 Oct 11, 2019
@sidharthachatterjee sidharthachatterjee force-pushed the pieh:logs-to-redux branch from ea92567 to 57c8a47 Oct 11, 2019
sidharthachatterjee and others added 7 commits Oct 11, 2019
Copy link
Member

wardpeet left a comment

Thanks for doing all the hard work and listening to all my comments! I'm so excited to get this merged in! 👏 🥇

@sidharthachatterjee sidharthachatterjee merged commit eafb8c6 into gatsbyjs:master Oct 14, 2019
21 checks passed
21 checks passed
Danger All good
Details
Peril All green. Well done.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 67 tests passed in 00:28
Details
unit_tests_windows Build #20191011.107 succeeded
Details
OSS Roadmap automation moved this from In progress to Done Oct 14, 2019
@sidharthachatterjee sidharthachatterjee deleted the pieh:logs-to-redux branch Oct 14, 2019
@sidharthachatterjee

This comment has been minimized.

Copy link
Member

sidharthachatterjee commented Oct 14, 2019

Published in gatsby@2.16.0 and gatsby-cli@2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OSS Roadmap
  
Done
6 participants
You can’t perform that action at this time.