Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-source-filesystem no longer accepts functions as ignore rule #27848

Closed
axe312ger opened this issue Nov 5, 2020 · 0 comments · Fixed by #27849
Closed

gatsby-source-filesystem no longer accepts functions as ignore rule #27848

axe312ger opened this issue Nov 5, 2020 · 0 comments · Fixed by #27849
Assignees
@axe312ger
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label type: bug An issue or pull request relating to a bug in Gatsby

Comments

@axe312ger
Copy link
Collaborator

Hey there,

using functions for the ignore rule in gatsby-source-filesystem was working fine till the recently released plugin options validation:

Invalid plugin options for "gatsby-source-filesystem", configured by ...
"ignore[0]" must be a string

source-filesystem uses chokidar/anymatch and they support regex and function ignores next to strings:

I guess the only thing to do is to extend the following plugin validation config:
https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-filesystem/src/gatsby-node.js#L160
@axe312ger axe312ger added the type: bug An issue or pull request relating to a bug in Gatsby label Nov 5, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 5, 2020
axe312ger added a commit to axe312ger/gatsby that referenced this issue Nov 5, 2020
@axe312ger
fix: allow regex and functions for ignore values
b61becb 
fixes gatsbyjs#27848
@axe312ger axe312ger self-assigned this Nov 5, 2020
@axe312ger axe312ger mentioned this issue Nov 5, 2020
Merged
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 6, 2020
mxstbr added a commit that referenced this issue Nov 6, 2020
@axe312ger @mxstbr
fix(gatsby-source-filesystem): allow regex and functions for ignore o…
253b1af 
…ption

fixes #27848

Co-authored-by: Max Stoiber <contact@mxstbr.com>
vladar pushed a commit that referenced this issue Nov 6, 2020
@axe312ger @vladar
fix(gatsby-source-filesystem): allow regex and functions for ignore o…
67ce4f4 
…ption

fixes #27848

Co-authored-by: Max Stoiber <contact@mxstbr.com>
(cherry picked from commit 253b1af)
mwfrost pushed a commit to mwfrost/gatsby that referenced this issue Apr 20, 2023
@axe312ger @mxstbr
fix(gatsby-source-filesystem): allow regex and functions for ignore o…
5060a7c 
…ption

fixes gatsbyjs#27848

Co-authored-by: Max Stoiber <contact@mxstbr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axe312ger axe312ger

Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gatsby-source-filesystem): allow regex and functions for ignore option gatsbyjs/gatsby
2 participants
@axe312ger @LekoArts