Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial/docs: Mention/add favicon.ico #8366

Closed
2 tasks
amberleyromo opened this issue Sep 20, 2018 · 8 comments
Closed
2 tasks

Tutorial/docs: Mention/add favicon.ico #8366

amberleyromo opened this issue Sep 20, 2018 · 8 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@amberleyromo
Copy link
Contributor

amberleyromo commented Sep 20, 2018

  • /tutorial/part-eight/
  • /docs/add-a-manifest-file

https://twitter.com/jlengstorf/status/1042537527544963073

@amberleyromo amberleyromo self-assigned this Sep 20, 2018
@amberleyromo amberleyromo added Hacktoberfest good first issue Issue that doesn't require previous experience with Gatsby labels Oct 27, 2018
@amberleyromo amberleyromo removed their assignment Oct 27, 2018
@nclandrei
Copy link

Hi @amberleyromo! Can I take this one on? 😄

@LuisPaGarcia
Copy link

Hi, @amberleyromo!
Can i take this one?

@amberleyromo
Copy link
Contributor Author

@nclandrei -- go for it, thank you!

@LuisPaGarcia ^another contributor commented first! You might be interested in checking out the other hacktoberfest issues 😄

@LekoArts LekoArts added the help wanted Issue with a clear description that the community can help with. label Jan 13, 2019
@hemakshis
Copy link
Contributor

Hi @amberleyromo, can I take this up? This would be my first issue to gatsbyjs. Also, it would be helpful if you could provide a little more detail on what needs to be done as the description is not much clear to me. Thank you :)

@LekoArts
Copy link
Contributor

Yeah, sure, go ahead @hemakshis 👍
https://github.com/gatsbyjs/gatsby/blob/master/docs/tutorial/part-eight/index.md#-using-gatsby-plugin-manifest
https://github.com/gatsbyjs/gatsby/blob/master/docs/docs/add-a-manifest-file.md#using-gatsby-plugin-manifest

Both need an update after step 1 to tell the users that they need to place an image (which then will be their favicon) at src/images/icon.png.

@hemakshis
Copy link
Contributor

Hi @LekoArts, I have submitted a PR #11071. Please let me know if any changes are required 😃

Thank you!

@gatsbot
Copy link

gatsbot bot commented Feb 15, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 15, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 26, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Feb 26, 2019
marcysutton pushed a commit that referenced this issue Feb 26, 2019
* Tutorial/docs: Mention/add favicon.ico #8366

* Made code review changes

* Modified according to review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

8 participants