Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add https://www.markets.com/ to the site showcase #9342

Closed
KyleAMathews opened this issue Oct 24, 2018 · 2 comments · Fixed by #9345
Closed

Add https://www.markets.com/ to the site showcase #9342

KyleAMathews opened this issue Oct 24, 2018 · 2 comments · Fixed by #9345
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.

Comments

@KyleAMathews
Copy link
Contributor

https://www.gatsbyjs.org/docs/site-showcase-submissions/
@KyleAMathews KyleAMathews added help wanted Issue with a clear description that the community can help with. Hacktoberfest good first issue Issue that doesn't require previous experience with Gatsby labels Oct 24, 2018
@jishvi
Copy link
Contributor

jishvi commented Oct 24, 2018

May I work on it?

@KyleAMathews
Copy link
Contributor Author

@jishvi go for it!

@jishvi jishvi mentioned this issue Oct 24, 2018
Merged
pieh pushed a commit that referenced this issue Oct 24, 2018
@jishvi @pieh
feat(showcase): add https://www.markets.com (#9345)
4d5c5e0 
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Closes #9342
jedrichards pushed a commit to jedrichards/gatsby that referenced this issue Nov 1, 2018
@jishvi @jedrichards
feat(showcase): add https://www.markets.com (gatsbyjs#9345)
f744b36 
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Closes gatsbyjs#9342
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@jishvi @gpetrioli
feat(showcase): add https://www.markets.com (gatsbyjs#9345)
6d9a63a 
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Closes gatsbyjs#9342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added https://www.markets.com/ to the site showcase jishvi/gatsby
2 participants
@KyleAMathews @jishvi