Upgrading gatsby from 2.0.31 to 2.0.34 causes a Typerror #9559

jonleopard · 2018-10-30T13:01:59Z

Not sure what's causing this, it may be a plugin but I'm not sure where to even start.

Description

Upgrading gatsby from 2.0.31 to 2.0.34 causes a typerror:

$ gatsby develop                                                                                                                                               [75/2399]
success open and validate gatsby-configs — 0.011 s
error value must be an array of bytes


  TypeError: value must be an array of bytes

  - v35.js:29 generateUUID
    [jonleopard.com]/[uuid]/lib/v35.js:29:38

  - create-node-id.js:16 createNodeId
    [jonleopard.com]/[gatsby]/dist/utils/create-node-id.js:16:10

  - load.js:131 processPlugin
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:131:13

  - load.js:148 config.plugins.forEach.plugin
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:148:20

  - Array.forEach

  - load.js:147 module.exports
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:147:20

  - index.js:56
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/index.js:56:21

  - Generator.next

  - debuggability.js:313 Promise._execute
    [jonleopard.com]/[bluebird]/js/release/debuggability.js:313:9

  - promise.js:483 Promise._resolveFromExecutor
    [jonleopard.com]/[bluebird]/js/release/promise.js:483:18

  - promise.js:79 new Promise
    [jonleopard.com]/[bluebird]/js/release/promise.js:79:10

  - index.js:96
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/index.js:96:17


error UNHANDLED REJECTION


  TypeError: value must be an array of bytes

  - v35.js:29 generateUUID
    [jonleopard.com]/[uuid]/lib/v35.js:29:38

  - create-node-id.js:16 createNodeId
    [jonleopard.com]/[gatsby]/dist/utils/create-node-id.js:16:10

  - load.js:131 processPlugin
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:131:13

  - load.js:148 config.plugins.forEach.plugin
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:148:20

  - Array.forEach

  - load.js:147 module.exports
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/load.js:147:20

  - index.js:56
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/index.js:56:21

  - Generator.next

  - debuggability.js:313 Promise._execute
    [jonleopard.com]/[bluebird]/js/release/debuggability.js:313:9

  - promise.js:483 Promise._resolveFromExecutor
    [jonleopard.com]/[bluebird]/js/release/promise.js:483:18

  - promise.js:79 new Promise
    [jonleopard.com]/[bluebird]/js/release/promise.js:79:10

  - index.js:96
    [jonleopard.com]/[gatsby]/dist/bootstrap/load-plugins/index.js:96:17

Steps to reproduce

Upgraded all my gatsby plgugins as well as gatsby/gatsby-cli to the latest versions.

Expected result

gatsby develop should start with no errors.

Actual result

Received TypeError: value must be an array of bytes

Environment

System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
Shell: 5.6.2 - /usr/local/bin/zsh
Binaries:
Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.13.0/bin/npm
Browsers:
Chrome: 69.0.3497.100
Firefox: 63.0
Safari: 12.0
npmPackages:
gatsby: ^2.0.34 => 2.0.34
gatsby-cli: ^2.4.4 => 2.4.4
gatsby-codemods: ^1.0.6 => 1.0.6
gatsby-plugin-google-analytics: ^2.0.7 => 2.0.7
gatsby-plugin-netlify: ^2.0.3 => 2.0.3
gatsby-plugin-react-helmet: ^3.0.1 => 3.0.1
gatsby-plugin-sharp: ^2.0.10 => 2.0.10
gatsby-plugin-sitemap: ^2.0.2 => 2.0.2
gatsby-plugin-styled-components: ^3.0.1 => 3.0.1
gatsby-remark-prismjs: ^3.0.3 => 3.0.3
gatsby-source-contentful: ^2.0.9 => 2.0.9
gatsby-source-filesystem: ^2.0.6 => 2.0.6
gatsby-transformer-json: ^2.1.5 => 2.1.5
gatsby-transformer-remark: ^2.1.11 => 2.1.11
gatsby-transformer-sharp: ^2.1.7 => 2.1.7

The text was updated successfully, but these errors were encountered:

DSchau · 2018-10-30T13:20:09Z

@jonleopard would you be able to provide a reproduction?

For context, this is the line that appears to be throwing:

function createNodeId(id, namespace) {
  return uuidv5(id, uuidv5(namespace, seedConstant)); // here
}

Greegko · 2018-10-30T15:54:51Z

I had the same issue, in gatsyb-config.js file I had this:

module.exports = {
plugins: [
{
      resolve: `gatsby-plugin-sitemap`,
},
...
]

instead of simply

plugins: ['gatsby-plugin-sitemap', ...]

jonleopard · 2018-10-30T16:18:03Z

Thanks @Greegko, that worked for me! Mind if I ask how you managed to trace down that issue?

Greegko · 2018-10-30T16:28:03Z

@jonleopard Put console.log() with related context parameters before every createNodeId imported and called, at one place there was an undefined and more console log until I found it iterated over all plugins which gave me the plugin name. Just saw the differences between plugin declaration afterwards.

zvinless · 2018-10-30T16:50:19Z

Nice find @Greegko! Looks like you have to either use the shorthand syntax or at least supply an empty options object. Is that intentional? I was using the object syntax exclusively since having a uniform style made it clearer to read the plugins list.

kinduff · 2018-10-30T16:59:16Z

I can confirm that the fix provided by @Greegko fixes the issue.

Before

{
  resolve: `gatsby-transformer-remark`,
  options: {
    plugins: [
      {
        resolve: `gatsby-remark-relative-images`,
        options: {
          name: 'assets'
        }
      },
      {
        resolve: `gatsby-remark-images`,
      },
    ],
  },
}

After

{
  resolve: `gatsby-transformer-remark`,
  options: {
    plugins: [
      {
        resolve: `gatsby-remark-relative-images`,
        options: {
          name: 'assets'
        }
      },
      `gatsby-remark-images`, // changed
    ],
  },
}

DSchau · 2018-10-30T17:26:04Z

Yeah, so to sum up here, it looks like leaving options off a plugin with resolve reliably throws the error, correct?

We should fix it! Anyone want to jump on this? I'll close this one out and create a new issue in a second :)

t2ca · 2018-10-30T22:06:10Z

Thank you @Greegko, this was very helpful!

ken0x0a · 2018-10-31T02:05:35Z

Thank you @kinduff !!

jedrichards · 2018-10-31T13:29:32Z

@DSchau Hmm, I'm getting the same error after an update to Gatsby 2.0.35. For me it's unrelated to the shape of the gatsby-config object. Instead I get it when I include a local plugin in the config. My local plugin was working prior to the upgrade on Gatsby 2.0.19.

Edit: regression introduced in 2.0.33

cmsbased · 2018-10-31T19:48:51Z

Local plugin stopped working with same error since 2.0.33. Problem persists after 2.0.35 update. The @Greegko solution does not apply because local plugin contains options.

DSchau · 2018-10-31T19:56:11Z

@jedrichards @cmsbased just to clarify, by a local plugin you mean a project level plugins folder (e.g. plugins/gatsby-plugin-example) that is then declared/used in gatsby-config.js correct?

Do either of you have a reproduction handy? Otherwise I'll just make one quickly to confirm!

Also here's the diff between 2.0.32 and 2.0.33

DSchau · 2018-10-31T20:03:02Z

I've attempted to reproduce the issue here (using gatsby 2.0.35), and unable to do so. Possible there's a misunderstanding here, so would either of you be able to reproduce here? I've added you both as collaborators.

jedrichards · 2018-10-31T21:10:39Z

@DSchau @cmsbased I've managed to repro a bug. Here's a PR demoing it:

DSchau/gatsby-9559#1

Looks like it occurs for me when package.json in the local plugin is the empty object {}. The docs currently advise this:

https://www.gatsbyjs.org/docs/plugin-authoring/#what-files-does-gatsby-look-for-in-a-plugin

cmsbased · 2018-10-31T21:10:50Z

@DSchau It is a local plugin \gatsby-site\plugins\gatsby-source-custom

gatsby-config.js is set like this:

    {
      resolve: 'gatsby-source-custom',
      options: {
        baseUrl: 'http://custom.local',
      },
    },

Need to roll it back to version 2.0.31 to make it work. Problem persists with empty plugin.

DSchau · 2018-10-31T21:13:46Z

@jedrichards so the issue there is due to this change

We just need to tweak that logic a bit.

@cmsbased I don't think it's config related, do you also have an empty package.json?

cmsbased · 2018-10-31T21:14:55Z

@DSchau Yes. Empty package.json with {}

DSchau · 2018-10-31T21:16:11Z

Right, so the logic to tweak here is pretty simple!

In this file

we need to get the name up front, and then use it, e.g. like so:

const name = packageJSON.name || pluginName
return {
  resolve: resolvedPath,
  name,
  id: createNodeId(name, `Plugin`),
  version:
    packageJSON.version || createFileContentHash(resolvedPath, `**`),
}

either of you want to PR that? I'd appreciate it, otherwise I'll get to it soon!

jedrichards · 2018-11-01T16:55:59Z

@DSchau Here you go, in case it's needed:

#9636

…a name field fixes gatsbyjs#9559

…a name field (#9636) Fixes #9559

DSchau · 2018-11-01T20:33:50Z

Fixed in gatsby@2.0.37. I like to run yarn upgrade-interactive to grab the latest versions of things, but yarn add gatsby@^2.0.37 should do the trick, too!

zvinless · 2018-11-01T21:33:25Z

@DSchau thanks for checking this out! I'm still seeing the same error in 2.0.37. Here's my gatsby-config.js:

module.exports = {
    plugins: [
        {
            resolve: 'gatsby-plugin-react-helmet'
        }
    ]
}

adding an empty options object still fixes it, too

DSchau · 2018-11-01T21:34:35Z

@zvinless that seems like a separate issue! Interesting in fixing it? It's probably a regression introduced in the same release (2.0.33) I posted above!

zvinless · 2018-11-01T22:16:24Z

Sure, I'll give it a shot

Fixes issue at the end of #9559, e.g.: ```javascript module.exports = { plugins: [ { resolve: 'gatsby-plugin-react-helmet' } ] } ``` where the plugin is loaded using object syntax but no `options` object is defined. This wasn't caught by the unit test because the issue was occurring after the early out when it's the `___TEST___` plugin.

…a name field (gatsbyjs#9636) Fixes gatsbyjs#9559

Fixes issue at the end of gatsbyjs#9559, e.g.: ```javascript module.exports = { plugins: [ { resolve: 'gatsby-plugin-react-helmet' } ] } ``` where the plugin is loaded using object syntax but no `options` object is defined. This wasn't caught by the unit test because the issue was occurring after the early out when it's the `___TEST___` plugin.

kinduff mentioned this issue Oct 30, 2018

TypeError: getNodesByType is not a function #9533

Closed

DSchau closed this as completed Oct 30, 2018

jedrichards added a commit to jedrichards/gatsby that referenced this issue Nov 1, 2018

Make local plugin resolution resilient to package.json files without …

68f43fd

…a name field fixes gatsbyjs#9559

jedrichards mentioned this issue Nov 1, 2018

Make local plugin resolution resilient to package.json files without a name field #9636

Merged

DSchau pushed a commit that referenced this issue Nov 1, 2018

Make local plugin resolution resilient to package.json files without …

d8a6af4

…a name field (#9636) Fixes #9559

zvinless mentioned this issue Nov 1, 2018

fix: load plugin object style without options object #9647

Merged

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019

Make local plugin resolution resilient to package.json files without …

d9754aa

…a name field (gatsbyjs#9636) Fixes gatsbyjs#9559

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrading gatsby from 2.0.31 to 2.0.34 causes a Typerror #9559

Upgrading gatsby from 2.0.31 to 2.0.34 causes a Typerror #9559

jonleopard commented Oct 30, 2018

DSchau commented Oct 30, 2018

Greegko commented Oct 30, 2018

jonleopard commented Oct 30, 2018 •

edited

Greegko commented Oct 30, 2018

zvinless commented Oct 30, 2018

kinduff commented Oct 30, 2018

DSchau commented Oct 30, 2018

t2ca commented Oct 30, 2018

ken0x0a commented Oct 31, 2018

jedrichards commented Oct 31, 2018 •

edited

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018 •

edited

DSchau commented Oct 31, 2018

jedrichards commented Oct 31, 2018 •

edited

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018

jedrichards commented Nov 1, 2018 •

edited

DSchau commented Nov 1, 2018

zvinless commented Nov 1, 2018

DSchau commented Nov 1, 2018

zvinless commented Nov 1, 2018

Upgrading gatsby from 2.0.31 to 2.0.34 causes a Typerror #9559

Upgrading gatsby from 2.0.31 to 2.0.34 causes a Typerror #9559

Comments

jonleopard commented Oct 30, 2018

Description

Steps to reproduce

Expected result

Actual result

Environment

DSchau commented Oct 30, 2018

Greegko commented Oct 30, 2018

jonleopard commented Oct 30, 2018 • edited

Greegko commented Oct 30, 2018

zvinless commented Oct 30, 2018

kinduff commented Oct 30, 2018

DSchau commented Oct 30, 2018

t2ca commented Oct 30, 2018

ken0x0a commented Oct 31, 2018

jedrichards commented Oct 31, 2018 • edited

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018 • edited

DSchau commented Oct 31, 2018

jedrichards commented Oct 31, 2018 • edited

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018

cmsbased commented Oct 31, 2018

DSchau commented Oct 31, 2018

jedrichards commented Nov 1, 2018 • edited

DSchau commented Nov 1, 2018

zvinless commented Nov 1, 2018

DSchau commented Nov 1, 2018

zvinless commented Nov 1, 2018

jonleopard commented Oct 30, 2018 •

edited

jedrichards commented Oct 31, 2018 •

edited

DSchau commented Oct 31, 2018 •

edited

jedrichards commented Oct 31, 2018 •

edited

jedrichards commented Nov 1, 2018 •

edited