Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a grammar error #11182

Closed
wants to merge 1 commit into from
Closed

fixed a grammar error #11182

wants to merge 1 commit into from

Conversation

tiagohermano
Copy link

@tiagohermano tiagohermano commented Jan 20, 2019

Description

Fixed grammar on the word 'mean' to 'means'

Related Issues

@tiagohermano tiagohermano requested a review from a team January 20, 2019 22:19
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tiagohermano! I think mean and means are both fine here. How about re-wording this sentence to avoid using that word? We can also explain what Jest is, which I think should be a bit clearer? Something like this:

- However there are a few features of the Gatsby build process that means the standard Jest setup doesn't quite work. This guide shows you how to set it up.
+ In this guide you'll learn how to run unit tests for your Gatsby site using a test framework called Jest.

@DSchau
Copy link
Contributor

DSchau commented Feb 6, 2019

@tiagohermano would you have some time to address the changes that @m-allanson suggested?

Please let us know, thank you!

@DSchau
Copy link
Contributor

DSchau commented Feb 18, 2019

Going to close this out--if you're able to make the changes @m-allanson suggested, we'd be happy to take another look.

Thanks for your contribution!

@DSchau DSchau closed this Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants