New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graphql, relay-compiler, graphql-relay and fix breaking change #11377
Update graphql, relay-compiler, graphql-relay and fix breaking change #11377
Conversation
Related: #9914 |
@stefanprobst From the tests I did the current version of relay compiler works fine with graphql@14. I’d rather keep this pr small if possible since updating the relay compiler might require other changes. |
|
Let's add relay-compiler upgrade to this too. It shouldn't affect us, but I don't feel it's right to upgrade graphql without upgrading relay-compiler. |
2170282
to
adf1aeb
Compare
@freiksenet Updated relay-compiler and graphql-relay to support graphql@14. Tested again and everything works fine with the updated relay-compiler and graphql-relay. |
@freiksenet I've tested this on our .org site and it seems to work.. $ yarn list | grep "graphql"
├─ babel-plugin-remove-graphql-queries@2.5.3
├─ eslint-plugin-graphql@2.1.1
│ ├─ graphql-config@^2.0.1
├─ express-graphql@0.6.12
│ ├─ babel-plugin-remove-graphql-queries@^2.5.3
│ ├─ eslint-plugin-graphql@^2.0.0
│ ├─ express-graphql@^0.6.12
│ ├─ graphql-playground-middleware-express@^1.7.10
│ ├─ graphql-relay@^0.6.0
│ ├─ graphql-skip-limit@^2.0.4
│ ├─ graphql-tools@^3.0.4
│ ├─ graphql-type-json@^0.2.1
│ ├─ graphql@^14.1.1
├─ graphql-config@2.2.1
│ ├─ graphql-import@^0.7.1
│ ├─ graphql-request@^1.5.0
│ ├─ graphql-request@1.8.2
├─ graphql-import@0.7.1
├─ graphql-playground-html@1.6.11
├─ graphql-playground-middleware-express@1.7.10
│ └─ graphql-playground-html@1.6.11
├─ graphql-relay@0.6.0
├─ graphql-request@1.6.0
├─ graphql-skip-limit@2.0.4
├─ graphql-tools@3.1.1
├─ graphql-type-json@0.2.1
├─ graphql@14.1.1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot and millions of kudos to @wardpeet for testing this.
Holy buckets, @janicduplessis — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
This fixes compatibility with graphql@14+ and updates the version for all packages.
The breaking change that affects us is the removal of
VariablesDefaultValueAllowed
.(https://github.com/graphql/graphql-js/releases/tag/v14.0.0)
Tested in a project by upgrading graphql to 14.1.1, also quicky audited the packages that use graphql to make sure they are not affected by breaking changes.
Before this change:
After:
Everything works 🙌
Related Issues
N/A