Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blog): add localization with gatsby and sanity #11684

Merged
merged 9 commits into from
Feb 27, 2019
Merged

feat(blog): add localization with gatsby and sanity #11684

merged 9 commits into from
Feb 27, 2019

Conversation

williamtstanley
Copy link
Contributor

Description

Blog post: A method of doing localization with Gatsby and Sanity.io

@williamtstanley williamtstanley requested a review from a team February 10, 2019 22:16
@williamtstanley williamtstanley changed the title Add a blog post about localization with gatsby and sanity Post: localization with gatsby and sanity Feb 10, 2019
@DSchau DSchau changed the title Post: localization with gatsby and sanity feat(blog): add localization with gatsby and sanity Feb 15, 2019
DSchau
DSchau reviewed Feb 15, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Generally I'm not quite sure whether this fits on the blog (and how we categorize what is blog-post worthy) because it's possibly a bit more focused than other content we've previously displayed on our blog.

That said--it's a great blog post, so I think we'd like to have this content somewhere (or link to it?), even if not our blog.

@marcysutton any ideas or suggestions here?

docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
@williamtstanley
Copy link
Contributor Author

This is looking great. Generally I'm not quite sure whether this fits on the blog (and how we categorize what is blog-post worthy) because it's possibly a bit more focused than other content we've previously displayed on our blog.

That said--it's a great blog post, so I think we'd like to have this content somewhere (or link to it?), even if not our blog.

@marcysutton any ideas or suggestions here?

Thanks I appreciate the feedback for sure. To be honest the only reason I wrote it was because I got a request to do so on twitter from @jlengstorf. ;)

@williamtstanley
Copy link
Contributor Author

Follow up after my edits... no idea why its failing the CI now. :(

@DSchau
Copy link
Contributor

DSchau commented Feb 15, 2019

@williamtstanley don't think it's actually failing! If multiple commits come in, it auto-cancels the older/redundant builds!

calcsam
calcsam approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@calcsam calcsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSchau @marcysutton I would say this is great blog post material.

This is great content, and there's only two options here, blog post or docs.

It would be tough to make this a canonical docs article, because we only have standalone canonical articles on one topic (eg Gatsby + Sanity or Gatsby + Localization) rather than the intersection of two topics (Gatsby + Sanity + Localization). If it was a blog post, however, we can link to it from our l10n / i18n articles.

Therefore, this should be a blog post.

marcysutton
marcysutton previously requested changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much for putting it together! I agree that it makes sense as a blog post...my only question is how it differs from the other Sanity post. What new information does this post provide, and can that go into the title somehow?

docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Outdated Show resolved Hide resolved
docs/blog/2019-03-01-localization-with-gatsby-and-sanity/index.md Show resolved Hide resolved
Travis Stanley and others added 4 commits February 19, 2019 18:33
Update text to reflect review
72014da 
Combine two sentence fragments to form a complete sentence. Fix a typo
and expend the link text to be more clear what the link was pointing to.

Also updated the working title to "A method of localization with gatsby
and sanity.io" <-- please suggest other options I am not in love with
this.
Merge remote-tracking branch 'upstream/master' into docs/gatsby-and-s…
7b33b67 
…anity-with-localization
@williamtstanley
Merge branch 'master' into docs/gatsby-and-sanity-with-localization
f340426
@DSchau
Merge branch 'master' into docs/gatsby-and-sanity-with-localization
e17bf23
@DSchau
Copy link
Contributor

DSchau commented Feb 26, 2019

@marcysutton I fixed up the merge conflict--we can merge posts ahead of their scheduled post date (currently March 1st) and they won't go live until that date.

Anything else that needs fixing up?

Thanks for the patience here @williamtstanley!

@marcysutton
Copy link
Contributor

Love it! :shipit:

@DSchau DSchau dismissed marcysutton’s stale review February 27, 2019 00:04

(Feedback addressed!)

DSchau
DSchau approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged. It'll go live March 1st--this Friday!

(Holy cow, it's almost March!)

@DSchau DSchau merged commit 6d10f7c into gatsbyjs:master Feb 27, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 27, 2019

Holy buckets, @williamtstanley — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@williamtstanley
Copy link
Contributor Author

Unfortunately I found an issue with my post when considered against this bug. #5255
Basically if you are creating pages in gatsby-node you need to duplicate my onCreatePage logic.

@williamtstanley williamtstanley mentioned this pull request Mar 1, 2019
Merged
@williamtstanley williamtstanley deleted the docs/gatsby-and-sanity-with-localization branch March 2, 2019 02:59
DSchau pushed a commit that referenced this pull request Mar 7, 2019
@williamtstanley @DSchau
chore(blog): fix code in sanity blog post (#12201)
9b11381 
## Description
`createPages` doesn't trigger onCreatePage in the same plugin so I added
an extra bit of example code to demonstrate that.

## Update to
#11684

## Related Issues
Related to #5255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

@calcsam calcsam calcsam approved these changes

@marcysutton marcysutton marcysutton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@williamtstanley @DSchau @marcysutton @calcsam