Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): fix code in sanity blog post #12201

Conversation

williamtstanley
Copy link
Contributor

@williamtstanley williamtstanley commented Mar 1, 2019

Description

createPages doesn't trigger onCreatePage in the same plugin so I added
an extra bit of example code to demonstrate that.

Update to

#11684

Related Issues

Related to #5255

`createPages` doesn't trigger onCreatePage in the same plugin so I added
an extra bit of example code to demonstrate that.
@williamtstanley williamtstanley requested a review from a team March 1, 2019 06:29
@williamtstanley williamtstanley changed the title Additional code required for programatic page generation feat(blog): UPDATE -> add localization with gatsby and sanity Mar 1, 2019
@wardpeet wardpeet added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Mar 1, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit/typo otherwise this looks good, thanks!

Co-Authored-By: williamtstanley <william.t.stanley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants