fix(gatsby-source-shopify): fix query pagination #11752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
approved these changes
Feb 14, 2019
|
Verified locally, thank you @pieh 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix here is that
getwas usingfalseargument (for unknown reason) in place for data object, so the condition was never true.Just in case - issue that this PR is fixing can be reproduced by using https://github.com/gatsbyjs/store.gatsbyjs.org and monkey-patching
gatsby/packages/gatsby-source-shopify/src/lib.js
Line 41 in 67c0131
250 default limit is shopify's maximum (using more would cause query to error out)
fixes #11724