-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Stub List page #12418
feat(docs): Stub List page #12418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great contribution, thanks for the PR! I especially like how you're finding stubs dynamically so the list is easy to keep up to date. I wonder, though, if some test coverage could be added for the business logic so that we can ensure it doesn't break over time. Is that something you could work on?
Yeah definitely, I would have to look how to write tests for it, but I think it likely will be possible. Is there anywhere currently references for tests that are for logic for portions of the website? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We don't really have a ton of unit tests for our www code but we certainly could add some.
Maybe a separate PR?
Co-Authored-By: lannonbr <benjamin@lannonbr.com>
I'll go submit another commit to fix that lint error. @DSchau, I'd be up for a pair session with someone to do the tests if someone is available to do such. |
Opened up an issue for adding testing for the .org site: #12545. |
Let's revisit adding tests in a future PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! We'll implement a testing suite next week so we can get a sanity check for some of this new functionality :)
Description
I implemented a new page in the contributing section of the docs to aggregate all of the stubbed files in a single location so people can see any available articles that yet have to be written at a quick glance.
Related Issues
Closes #12362