-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): added quick tip for using host option with gatsby develop #16070
Conversation
@pieh do you have any specific platforms in mind that we could test? This worked for me on the Mac host side and I could view the IP address it output in the logs from the Windows VM side. |
My memory was it doesn't work on windows. But perhaps it was Linux. You can search old issues. This used to be the default host for a bit |
I think we should do some testing and see if it's feasible to set But in meantime I don't see harm with getting this one in? |
I think these instructions would help illustrate usage–where otherwise the list of options aren't necessarily motivated by use cases. We could add a note about platform inconsistencies to give people a heads up? |
I just did some tests with few platforms: Mac OS / Windows / Linux (Ubuntu). Windows and Linux were in virtual machines. I was running I was checking:
In my setup things worked in all possible combinations when using actual IP addresses (or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to ship! Thank you so much @gillkyle 🥇
Description
Added a note based on a tip from a tweet that people seem to be enjoying: https://twitter.com/nelsreitz/status/1154131687950954497
Note: @pieh mentioned that 0.0.0.0 might not work on all platforms