Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added quick tip for using host option with gatsby develop #16070

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

gillkyle
Copy link
Contributor

Description

Added a note based on a tip from a tweet that people seem to be enjoying: https://twitter.com/nelsreitz/status/1154131687950954497

Note: @pieh mentioned that 0.0.0.0 might not work on all platforms

@gillkyle gillkyle requested a review from a team as a code owner July 24, 2019 23:17
@marcysutton
Copy link
Contributor

@pieh do you have any specific platforms in mind that we could test? This worked for me on the Mac host side and I could view the IP address it output in the logs from the Windows VM side.

@KyleAMathews
Copy link
Contributor

My memory was it doesn't work on windows. But perhaps it was Linux. You can search old issues. This used to be the default host for a bit

@gillkyle
Copy link
Contributor Author

See also:

#171
#13128

Seems like maybe to specific of a tip to include based on discussion in those PRs.

@pieh
Copy link
Contributor

pieh commented Jul 25, 2019

I think we should do some testing and see if it's feasible to set 0.0.0.0 by default on platforms that are known to be working.

But in meantime I don't see harm with getting this one in?

@marcysutton
Copy link
Contributor

I think these instructions would help illustrate usage–where otherwise the list of options aren't necessarily motivated by use cases. We could add a note about platform inconsistencies to give people a heads up?

@pieh
Copy link
Contributor

pieh commented Jul 25, 2019

I just did some tests with few platforms: Mac OS / Windows / Linux (Ubuntu). Windows and Linux were in virtual machines.

I was running gatsby develop -H 0.0.0.0 on each platform and trying to access development server on all platforms. Using Chrome on Mac OS and Windows, using Firefox on Linux.

I was checking:

  • Initial load
  • Hot webpack update (code change)
  • Hot data update (content change)

In my setup things worked in all possible combinations when using actual IP addresses (or localhost:8000). Only thing that didn't work is trying to visit 0.0.0.0:8000 on Windows (works on Linux + Mac OS) - so to me it seems like we could try default to using 0.0.0.0 and instead just print out localhost for Windows as local URL (and maybe other platforms)

@lannonbr lannonbr added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jul 28, 2019
@DSchau DSchau added the status: awaiting author response Additional information has been requested from the author label Jul 30, 2019
@gillkyle gillkyle added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Aug 2, 2019
@sidharthachatterjee sidharthachatterjee removed the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Aug 6, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to ship! Thank you so much @gillkyle 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 6, 2019
@gatsbybot gatsbybot merged commit 05686ac into master Aug 6, 2019
@wardpeet wardpeet deleted the host-command-tip branch August 6, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants