-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default develop host to "localhost" on windows #171
Conversation
Windows won't resolve 0.0.0.0 as localhost/127.0.0.1 implicitly, so hot loading and link break. This just changes the default to a more (I think) helpful default for win32 users, rather then getting surprised by a default that doesn't work.
looks like some checks failed. ill look into it sometime today. |
its all lint, issues since the online editor doesn't give any feedback on that. I'll push a fix to them |
hmm sorry I don't quite understand what to do to fix this, it seems the eslint wants es6 code, but the rest of the file seems to be intentionally es5. |
Yeah — I've kept the bin scripts as es5 to avoid having to compile them in place on publishing (is there a better solution?). I just went ahead and disabled eslint completely on that file and merged your fix in. Thanks! |
@KyleAMathews I just installed the tutorial-part-one today (Nov. 19, 2017) and ran into the HMR trying to hit 0.0.0.0 Running Windows 10 x64
"develop": "gatsby develop -H 127.0.0.1", I don't mind this, but just wanted you to know. |
Hiya @jquense! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Windows won't resolve 0.0.0.0 as localhost/127.0.0.1 implicitly, so hot loading and links break. This just changes the default to a more (I think) helpful default for win32 users, rather then getting surprised by a default that doesn't work.
(fair warning I wrote this in the browser editor, so sorry if something is off)