Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default develop host to "localhost" on windows #171

Merged
merged 1 commit into from
Mar 5, 2016

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Mar 5, 2016

Windows won't resolve 0.0.0.0 as localhost/127.0.0.1 implicitly, so hot loading and links break. This just changes the default to a more (I think) helpful default for win32 users, rather then getting surprised by a default that doesn't work.

(fair warning I wrote this in the browser editor, so sorry if something is off)

Windows won't resolve 0.0.0.0 as localhost/127.0.0.1 implicitly, so hot loading and link break. This just changes the default to a more (I think) helpful default for win32 users, rather then getting surprised by a default that doesn't work.
@NogsMPLS
Copy link
Contributor

NogsMPLS commented Mar 5, 2016

looks like some checks failed. ill look into it sometime today.

@jquense
Copy link
Contributor Author

jquense commented Mar 5, 2016

its all lint, issues since the online editor doesn't give any feedback on that. I'll push a fix to them

@jquense
Copy link
Contributor Author

jquense commented Mar 5, 2016

hmm sorry I don't quite understand what to do to fix this, it seems the eslint wants es6 code, but the rest of the file seems to be intentionally es5.

@KyleAMathews KyleAMathews merged commit 6543ece into gatsbyjs:master Mar 5, 2016
@KyleAMathews
Copy link
Contributor

Yeah — I've kept the bin scripts as es5 to avoid having to compile them in place on publishing (is there a better solution?). I just went ahead and disabled eslint completely on that file and merged your fix in.

Thanks!

@talves
Copy link
Contributor

talves commented Nov 19, 2017

@KyleAMathews I just installed the tutorial-part-one today (Nov. 19, 2017) and ran into the HMR trying to hit 0.0.0.0
image

Running Windows 10 x64

All working when I changed No 'Access-Control-Allow-Origin' header when changing to and hitting the site at http://localhost:8000, so have to run http://127.0.0.1:8000

    "develop": "gatsby develop -H 127.0.0.1",

I don't mind this, but just wanted you to know.

@jlengstorf
Copy link
Contributor

Hiya @jquense! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants