fix(gatsby-theme-notes): Use basePath as home breadcrumb link

[jakewies]

Description

Use the basePath option in gatsby-theme-notes to construct the link of the home breadcrumb icon.

Related Issues

Fixes #15494

[sidharthachatterjee]

@jakewies Is this still necessary now that #16556 is in?

[jakewies]

@sidharthachatterjee yes, it solves a different problem. However, if you read #15494 (comment) I brought up an issue that sticks out to me. If others agree with the issue, then I can re-work this PR.

[sidharthachatterjee]

@jakewies Just saw the comment. The issue and your proposed solutions makes sense to me!

[jakewies]

Ok great I'll make that change in this PR 👍

[sidharthachatterjee]

Sounds good! Thanks @jakewies 👍

[jakewies]

@sidharthachatterjee so i definitely seem to have made a mistake here 😢

Sorry, still new at contributing to OSS. Let me see if I can explain:

I tried to update my PR branch locally with recent changes to the master branch, so here's what I've done:

# locally

git fetch upstream
git checkout master
git merge upstream/master

# check out local PR branch

git checkout themes/fix-breadcrumb-home-link
git rebase master

# make changes and commit

git commit -m "stuff"

# here's where things got fuzzy...

git push

I wasn't able to push and git informed me about a failed "non-fast-forward" (I should've taken a snapshot of the actual message, but I imagine this is pretty common for newcomers?).

I did some googling after the fact and came across this helpful Stackoverflow explanation.

So the main thing is:

Did I make a mistake by rebasing on master in the first place?

And how would I go about resolving this current predicament?

And finally, what should I have done to update this PR with recent changes from master so this never happens again 😅 Thanks!

[sidharthachatterjee]

@jakewies No worries at all. It happens to the best of us! I think what happened is what you probably forgot to run git rebase --continue and committed instead?

I merged master in and fixed it. Typically I've seen that git merge master tends to be easier than git rebase master since a rebase goes commit by commit and a merge does not.

[jakewies]

Ok awesome! So, just to recap:

The home breadcrumb is now linked to the basePath:

# home breadcrumb links to basePath

~ / example-dir

This structure also supports nested notes:

~ / example-dir / nested-dir

However, it seems that gatsby-node.js constructs the breadcrumbs in a way that prevents nested "breadcrumbs" from working. This doesn't mean that nested notes can't work in a project, it just means that nested breadcrumbs are broken.

# because of how gatsby-node constructs breadcrumbs, nested-dir
# will point to `basePath/nested-dir`, instead of `basePath/example-dir/nested-dir

~ / example-dir / nested-dir

I can make a fix for this as well if need be.

[sidharthachatterjee]

This looks good for now! Thank you so much @jakewies

Regarding nested notes, we don't currently them in the theme anyway so let's hold onto that

I think @ChristopherBiscardi is looking at cleaning this up shortly anyway