feat(gatsby-plugin-netlify-cms): Add includeRobots #16662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdukart
force-pushed
the
netlify-cms-noindex
branch
from
277095a
to
9279f80
Compare
sidharthachatterjee
suggested changes
Aug 15, 2019
| @@ -161,6 +162,9 @@ exports.onCreateWebpackConfig = ( | |||
| favicon: htmlFavicon, | |||
| chunks: [`cms`], | |||
| excludeAssets: [/cms.css/], | |||
| meta: { | |||
| robots: excludeRobots ? `noindex` : ``, // Ensure search engines don't index this page. | |||
There was a problem hiding this comment.
Suggested change
| robots: excludeRobots ? `noindex` : ``, // Ensure search engines don't index this page. | |
| robots: excludeRobots ? `none` : `all`, // Ensure search engines don't index or follow links on this page |
| @@ -178,6 +178,13 @@ bar). | |||
| Customize the value of the `favicon` tag in your CMS HTML (shows in the browser | |||
| bar). | |||
|
|
|||
| ### `excludeRobots` | |||
There was a problem hiding this comment.
Let's flip this over to includeRobots since this is opt-in and by default it is not included
sidharthachatterjee
force-pushed
the
netlify-cms-noindex
branch
from
9279f80
to
10cd295
Compare
sidharthachatterjee
approved these changes
Aug 16, 2019
sidharthachatterjee
changed the title
noindex to Netlify CMS page
sidharthachatterjee
added
the
bot: merge on green
|
Holy buckets, @tdukart — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Published in |
|
Woo! Thanks for your quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
gatsby-plugin-netlify-cmsAdds a meta tag to the<head>of the Netlify CMS to request robots (like Googlebot) to not index the page. That way the admin can be hidden from search engines since it's not something that many (most?) site owners want publicly accessible.It's on by default but I added an option to the config so it can be turned off if the site owner desires.
Related Issues
None (can make one if you want)