Add support for json/yaml/toml pages #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #124 |
KyleAMathews
added a commit
that referenced
this pull request
Mar 13, 2016
Add support for json/yaml/toml pages
|
Looks good to me! |
|
@fson thanks! |
oscar-b
added a commit
to oscar-b/gatsby
that referenced
this pull request
Oct 25, 2017
Line gatsbyjs#187 does `/ desiredAspectRatio`, this calculation should probably be the same? I'm getting incorrect heights when querying images from Contentful. This change has not been tested yet, but the mistake seems obvious?
oscar-b
added a commit
to oscar-b/gatsby
that referenced
this pull request
Oct 26, 2017
Line gatsbyjs#187 does `/ desiredAspectRatio`, this calculation should probably be the same? I'm getting incorrect heights when querying images from Contentful.
KyleAMathews
pushed a commit
that referenced
this pull request
Oct 26, 2017
Line #187 does `/ desiredAspectRatio`, this calculation should probably be the same? I'm getting incorrect heights when querying images from Contentful.
wardpeet
added a commit
that referenced
this pull request
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a PR against the default starter with examples of using json/yaml/toml.
PR: gatsbyjs/gatsby-starter-default#7
Demo: http://peddler-ape-15755.netlify.com/
@fson I standardized how data is loaded for pages which modified how the HTML frontmatter data is loaded. As you're the only one I know of using that — can you verify I didn't break anything in your setup?