Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-typescript): Broader webpack support #22003

Merged
merged 1 commit into from
Mar 6, 2020
Merged

fix(gatsby-plugin-typescript): Broader webpack support #22003

merged 1 commit into from
Mar 6, 2020

Conversation

nemophrost
Copy link
Contributor

Description

Support Webpacks's rule.loader shortcut syntax in typescript plugin

Documentation

Module | webpack

Related Issues

Fixes #22002

@nemophrost nemophrost requested a review from a team as a code owner March 6, 2020 02:56
@vladar
Copy link
Contributor

vladar commented Mar 6, 2020

This makes sense for me but I am not a webpack expert at all. So @wardpeet @blainekasten what do you think?

wardpeet
wardpeet approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks

@TylerBarnes TylerBarnes merged commit 4b93826 into gatsbyjs:master Mar 6, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 6, 2020

Holy buckets, @nemophrost — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@nemophrost nemophrost deleted the gatsby-plugin-typescript-eslint-loader-fix branch March 6, 2020 23:04
wardpeet added a commit to wardpeet/gatsby that referenced this pull request Mar 16, 2020
@wardpeet
Revert "fix(gatsby-plugin-typescript): Broader webpack support (gatsb…
0018b95 
…yjs#22003)"

This reverts commit 4b93826.
wardpeet added a commit that referenced this pull request Mar 16, 2020
@wardpeet
Revert "feat(gatsby-plugin-typescript): Supports linting (#187… (#22308)
8c581c7 
* Revert "fix(gatsby-plugin-typescript): Broader webpack support (#22003)"

This reverts commit 4b93826.

* Revert "feat(gatsby-plugin-typescript): Supports linting (#18721)"

This reverts commit d28a0bd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(gatsby-plugin-typescript): eslint configuration broken with webpack rule.loader shortcut
4 participants
@nemophrost @vladar @wardpeet @TylerBarnes