fix(gatsby): Resolve linked interfaces consistently with object and union types #21936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladar
force-pushed
the
vladar/iface-link-perf-fix
branch
from
0827764
to
a6bc350
Compare
|
Published in Thanks @vladar ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a performance issue with resolving of linked interface fields. We've discovered that
Is much slower than
We had a special path for interfaces which was introduced in #17942
But this doesn't seem necessary anymore. Tests are passing without it. Tried this PR on a local project with schema customization. It gave a 10x speed increase for this kind of query.
Documentation
N/A - this is a performance fix
Related issues:
kontent-ai/gatsby-packages#107