Start Recipes GraphQL server during gatsby develop #23733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: recipes
and removed
status: triage needed
mxstbr
force-pushed
the
idempotent-recipes-server
branch
from
f925e65
to
be319ea
Compare
mxstbr
force-pushed
the
idempotent-recipes-server
branch
from
be319ea
to
35a7fea
Compare
mxstbr
changed the title
|
The only failing CI is "Cloud Tests", which fail with this error: This makes no sense because this module exists, a) I can see it locally but more importantly b) all other tests (including those touching the same code paths) pass! 🤔 Does anybody have an idea why this happens? |
freiksenet
reviewed
May 20, 2020
freiksenet
suggested changes
May 20, 2020
freiksenet
previously approved these changes
May 20, 2020
ascorbic
reviewed
May 20, 2020
ascorbic
reviewed
May 20, 2020
freiksenet
approved these changes
May 21, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the service discovery mechanism introduced in #22759 to idempotently start the recipes GraphQL server during
gatsby develop. That means if somebody runsgatsby recipeswhile they are already developing their site it will be much faster.This is also an important step along the way to Admin, which will query the same GraphQL server while develop is running. (reference draft PR: #23734)