-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend image seo for blog theme #23982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 11, 2020
laurieontech
added
topic: themes
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
May 11, 2020
johno
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻🖼️
freiksenet
pushed a commit
that referenced
this pull request
May 13, 2020
* Blog theme - Allow users to toggle off gatsby-plugin-theme-ui (#23180) * Initial implementation of theme-ui override, currently incompatable * Create toggle for gatsby-plugin-theme-ui * Create toggle for gatsby-plugin-theme-ui * Remove test state in starter * Fix prettier error and use destructuring for clarity * remove prettier parens now that prettierrc is updated * Update packages/gatsby-theme-blog/gatsby-node.js Co-Authored-By: John Otander <johnotander@gmail.com> Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> Co-authored-by: John Otander <johnotander@gmail.com> * Blog theme - Add images for social sharing (#23107) * Add images for social sharing in blog theme * Update READMEs * Add proptype Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> * Add featured image (#23757) * add featured image * Add featured image * undo package.json change Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> * Variable excerpt length (#23787) * Add separate social image field * Allow user to specify excerpt length * remove social image for this PR * remove social image for this PR * forgot to save before commit... Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> * Add separate social image field (#23786) Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> * Add support for image URLs as well as relative paths (#23765) * Add featured image * testing graphql * vlad pairing * fix invalid extension/resolver * ugly version * use absolute path * remove testing files from starter * remove comments * remove other temp starter testing * remove duplicate imageAlt after merge * validate URL using node library instead Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> * README updates * Theme blog image resolution (#23879) * Custom resolver for image * redo image resolution code * remove comments Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> * Delete README.md.rej * Update README.md * Update README.md * chore: format * remove image from posts query * readme should say default is 140 char * improve aria label for switch * tmp * Extend image seo for blog theme (#23982) * Update SEO * Update SEO Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> * Webfont option for blog theme (#24011) * support webfontURL * use helmet instead Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home> Co-authored-by: John Otander <johnotander@gmail.com> Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make use of alt text in social cards as well.